From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, almasrymina@google.com, sdf@fomichev.me,
netdev@vger.kernel.org, asml.silence@gmail.com, dw@davidwei.uk,
skhawaja@google.com, kaiyuanz@google.com, jdamato@fastly.com
Subject: Re: [PATCH net v4] net: devmem: fix kernel panic when netlink socket close after module unload
Date: Tue, 13 May 2025 07:30:16 -0700 [thread overview]
Message-ID: <20250513073016.2ab40a90@kernel.org> (raw)
In-Reply-To: <CAMArcTXOS4z6v5c2JCdAVg0RKjnoovrftx=cjt-09RXp29NW3Q@mail.gmail.com>
On Tue, 13 May 2025 12:24:52 +0900 Taehee Yoo wrote:
> > On Mon, 12 May 2025 08:40:59 +0000 Taehee Yoo wrote:
> > > @@ -943,8 +943,6 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)
> > > goto err_unbind;
> > > }
> > >
> > > - list_add(&binding->list, &priv->bindings);
> >
> > Please leave this list_add() where it was.
>
> list_add() is moved to net_devmem_bind_dmabuf() by this patch.
> So, you mean that let's make net_devmem_{bind | unbind}_dmabuf()
> don't handle list themself like the v3 patch, right?
Not exactly like in v3. In v3 list_del() was moved. I think these moves
are due to cleanup which I requested earlier? There is no functional
need for these? I'm giving up on that cleanup request for now.
Let's leave the list modifications where they are.
next prev parent reply other threads:[~2025-05-13 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 8:40 [PATCH net v4] net: devmem: fix kernel panic when netlink socket close after module unload Taehee Yoo
2025-05-12 23:46 ` Stanislav Fomichev
2025-05-13 0:02 ` Mina Almasry
2025-05-13 0:44 ` Jakub Kicinski
2025-05-13 3:24 ` Taehee Yoo
2025-05-13 14:30 ` Jakub Kicinski [this message]
2025-05-14 5:42 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513073016.2ab40a90@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=ap420073@gmail.com \
--cc=asml.silence@gmail.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kaiyuanz@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.