From: Lee Jones <lee@kernel.org>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v8 02/11] mfd: Add max7360 support
Date: Tue, 13 May 2025 10:31:07 +0100 [thread overview]
Message-ID: <20250513093107.GC2936510@google.com> (raw)
In-Reply-To: <D9UW14SJQ9HV.3BA1FYKMG9DE0@bootlin.com>
On Tue, 13 May 2025, Mathieu Dubois-Briand wrote:
> On Mon May 12, 2025 at 11:21 AM CEST, Andy Shevchenko wrote:
> > On Fri, May 09, 2025 at 11:14:36AM +0200, mathieu.dubois-briand@bootlin.com wrote:
> >
> >> +#define MAX7360_REG_GPIO_LAST 0x5F
> >
> >> +#define MAX7360_FIFO_EMPTY 0x3f
> >> +#define MAX7360_FIFO_OVERFLOW 0x7f
> >
> > Please, be consistent in style of the values.
>
> Is your point about the alignment of the values? Most of these are
> aligned on column 41, including the ones above. I just have an exception
> with MAX7360_PORT_CFG_*, as they are a bit too long. But as we are using
> tabs here, indentation appears a bit broken in the patch.
I believe the point was in reference to capitalisation.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-05-13 9:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 9:14 [PATCH v8 00/11] Add support for MAX7360 Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 01/11] dt-bindings: mfd: gpio: Add MAX7360 Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 02/11] mfd: Add max7360 support mathieu.dubois-briand
2025-05-09 9:29 ` Christophe JAILLET
2025-05-09 9:53 ` Mathieu Dubois-Briand
2025-05-12 9:21 ` Andy Shevchenko
2025-05-13 8:25 ` Mathieu Dubois-Briand
2025-05-13 9:31 ` Lee Jones [this message]
2025-05-13 11:14 ` Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 03/11] pinctrl: Add MAX7360 pinctrl driver Mathieu Dubois-Briand
2025-05-12 9:16 ` Andy Shevchenko
2025-05-09 9:14 ` [PATCH v8 04/11] pwm: max7360: Add MAX7360 PWM support mathieu.dubois-briand
2025-05-13 10:08 ` Uwe Kleine-König
2025-05-15 7:14 ` Mathieu Dubois-Briand
2025-05-16 12:57 ` Mathieu Dubois-Briand
2025-05-19 13:13 ` Andy Shevchenko
2025-05-09 9:14 ` [PATCH v8 05/11] regmap: irq: Add support for chips without separate IRQ status Mathieu Dubois-Briand
2025-05-14 9:59 ` Mark Brown
2025-05-14 11:59 ` Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 06/11] gpio: regmap: Allow to allocate regmap-irq device Mathieu Dubois-Briand
2025-05-19 13:16 ` Andy Shevchenko
2025-05-09 9:14 ` [PATCH v8 07/11] gpio: regmap: Allow to provide init_valid_mask callback Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 08/11] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2025-05-19 13:19 ` Andy Shevchenko
2025-05-20 13:33 ` Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 09/11] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 10/11] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2025-05-09 9:14 ` [PATCH v8 11/11] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
2025-05-23 15:55 ` (subset) [PATCH v8 00/11] Add support for MAX7360 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513093107.GC2936510@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=mwalle@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.