From: Trevor Woerner <twoerner@gmail.com>
To: Antonin Godard <antonin.godard@bootlin.com>
Cc: Quentin Schulz <quentin.schulz@cherry.de>, docs@lists.yoctoproject.org
Subject: Re: [docs] [PATCH] sphinx-lint: various fixes
Date: Tue, 13 May 2025 09:16:05 -0400 [thread overview]
Message-ID: <20250513131605.GB31516@localhost> (raw)
In-Reply-To: <D9UVUL1RJXK9.HT6YMHKRHD36@bootlin.com>
On Tue 2025-05-13 @ 10:17:05 AM, Antonin Godard wrote:
> On Mon May 12, 2025 at 11:03 PM CEST, Trevor Woerner via lists.yoctoproject.org wrote:
> > On Mon 2025-05-12 @ 09:50:07 AM, Quentin Schulz wrote:
> >> Hi Trevor,
> >>
> >> On 5/6/25 8:03 PM, Trevor Woerner via lists.yoctoproject.org wrote:
> >> > A 'make sphinx-lint' pass found the following issues:
> >> > trailing-whitespace
> >> > missing-space-after-literal
> >> > role-with-double-backticks
> >> > missing-space-before-role (role missing opening tag colon)
> >> >
> >>
> >> I'll let Antonin confirm but I assume it would be a good idea to have
> >> separate commits so we could easily backport them to earlier releases? Or
> >> maybe you/someone can run sphinx-lint on older releases and send patches for
> >> those too?
> >
> > okay, waiting on Antonin
>
> Ultimately the best approach would be to run sphinx-lint on each branch, because
> we might miss some lint warnings by simply backporting this patch.
>
> Do you want to take care of it?
Sure. In addition to master assume you want:
- kirkstone
- scarthgap
- walnascar
?
> >>
> >> The changes look fine (and necessary) to me :)
> >>
> >> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> >>
> >> [...]
> >>
> >> > diff --git a/documentation/dev-manual/start.rst b/documentation/dev-manual/start.rst
> >> > index 0f015d434041..21d3dce58c14 100644
> >> > --- a/documentation/dev-manual/start.rst
> >> > +++ b/documentation/dev-manual/start.rst
> >> > @@ -860,7 +860,7 @@ Initializing the Build Environment
> >> > Before you can use Yocto you need to setup the build environment.
> >> > From within the ``poky`` directory, source the :ref:`ref-manual/structure:\`\`oe-init-build-env\`\`` environment
> >> > setup script to define Yocto Project's build environment on your build host::
> >> > -
> >> > - $ source oe-init-build-env
> >> > +
> >> > + $ source oe-init-build-env
> >>
> >> You could also remove one whitespace before the $ to respect the
> >> "code-blocks are aligned by three whitespaces" rule we have (and which seems
> >> to not be part of our documentation/standards.md :) ).
> >
> > ok
>
> I can do it when applying your patch on master-next if that's ok to you, that's
> an easy enough change. :)
Yes please.
next prev parent reply other threads:[~2025-05-13 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 18:03 [PATCH] sphinx-lint: various fixes Trevor Woerner
2025-05-12 7:50 ` [docs] " Quentin Schulz
2025-05-12 21:03 ` Trevor Woerner
2025-05-13 8:17 ` Antonin Godard
2025-05-13 13:16 ` Trevor Woerner [this message]
2025-05-16 13:34 ` Antonin Godard
2025-05-21 16:42 ` Antonin Godard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250513131605.GB31516@localhost \
--to=twoerner@gmail.com \
--cc=antonin.godard@bootlin.com \
--cc=docs@lists.yoctoproject.org \
--cc=quentin.schulz@cherry.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.