From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: Mikko Korhonen <mjkorhon@gmail.com>, linux-ide@vger.kernel.org
Subject: [PATCH 6/7] ata: libata-eh: Host support has nothing to do with disabling DIPM
Date: Wed, 14 May 2025 19:22:16 +0200 [thread overview]
Message-ID: <20250514172210.383801-15-cassel@kernel.org> (raw)
In-Reply-To: <20250514172210.383801-9-cassel@kernel.org>
It makes sense to take host support for DIPM into account when
enabling DIPM, however, it makes zero sense to take host support
into account when disabling DIPM.
If the host does not support DIPM, that is a very good reason to
not keep the feature enabled on the device side.
Signed-off-by: Niklas Cassel <cassel@kernel.org>
---
drivers/ata/libata-eh.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index bc3654265053..91d97d98eed1 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -3473,8 +3473,7 @@ static int ata_eh_set_lpm(struct ata_link *link, enum ata_lpm_policy policy,
hints &= ~ATA_LPM_HIPM;
/* disable DIPM before changing link config */
- if (policy < ATA_LPM_MED_POWER_WITH_DIPM &&
- (dev_has_dipm && host_has_dipm)) {
+ if (policy < ATA_LPM_MED_POWER_WITH_DIPM && dev_has_dipm) {
err_mask = ata_dev_set_feature(dev,
SETFEATURES_SATA_DISABLE, SATA_DIPM);
if (err_mask && err_mask != AC_ERR_DEV) {
--
2.49.0
next prev parent reply other threads:[~2025-05-14 17:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 17:22 [PATCH 0/7] ata_eh_set_lpm() cleanups Niklas Cassel
2025-05-14 17:22 ` [PATCH 1/7] ata: libata-eh: Update DIPM comments to reflect reality Niklas Cassel
2025-05-14 17:22 ` [PATCH 2/7] ata: libata-eh: Add ata_eh_set_lpm() WARN_ON Niklas Cassel
2025-05-15 12:38 ` Damien Le Moal
2025-05-14 17:22 ` [PATCH 3/7] ata: libata-eh: Drop dipm variable Niklas Cassel
2025-05-15 12:39 ` Damien Le Moal
2025-05-14 17:22 ` [PATCH 4/7] ata: libata-eh: Introduce dev_has_dipm and dev_has_hipm variables Niklas Cassel
2025-05-14 17:22 ` [PATCH 5/7] ata: libata-eh: Rename no_dipm variable to be more clear Niklas Cassel
2025-05-14 17:22 ` Niklas Cassel [this message]
2025-05-14 17:22 ` [PATCH 7/7] ata: libata-eh: Always disable DIPM before calling set_lpm() callback Niklas Cassel
2025-05-15 12:42 ` Damien Le Moal
2025-05-15 12:59 ` Niklas Cassel
2025-05-15 13:04 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250514172210.383801-15-cassel@kernel.org \
--to=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=mjkorhon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.