All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>, Niklas Cassel <cassel@kernel.org>
Cc: Mikko Korhonen <mjkorhon@gmail.com>, linux-ide@vger.kernel.org
Subject: [PATCH v2 0/5] ata_eh_set_lpm() cleanups
Date: Thu, 15 May 2025 15:56:22 +0200	[thread overview]
Message-ID: <20250515135622.720623-7-cassel@kernel.org> (raw)

Hello all,

I was trying to understand ata_eh_set_lpm(), and decided that
it needed some cleanups to make the code more understandable.

Please have a look.


Changes since v1:
-Squashed patches 3 and 4 as requested by Damien.
-Squashed patches 6 and 7 as requested by Damien.
-Changed WARN_ON to WARN_ON_ONCE.
-Changed patch 1 to remove parts of a comment that is no longer true.


Niklas Cassel (5):
  ata: libata-eh: Update DIPM comments to reflect reality
  ata: libata-eh: Add ata_eh_set_lpm() WARN_ON_ONCE
  ata: libata-eh: Rename hipm and dipm variables
  ata: libata-eh: Rename no_dipm variable to be more clear
  ata: libata-eh: Keep DIPM disabled while modifying the allowed LPM
    states

 drivers/ata/libata-eh.c | 39 ++++++++++++++++++++++++++-------------
 1 file changed, 26 insertions(+), 13 deletions(-)

-- 
2.49.0


             reply	other threads:[~2025-05-15 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 13:56 Niklas Cassel [this message]
2025-05-15 13:56 ` [PATCH v2 1/5] ata: libata-eh: Update DIPM comments to reflect reality Niklas Cassel
2025-05-15 13:56 ` [PATCH v2 2/5] ata: libata-eh: Add ata_eh_set_lpm() WARN_ON_ONCE Niklas Cassel
2025-05-15 13:56 ` [PATCH v2 3/5] ata: libata-eh: Rename hipm and dipm variables Niklas Cassel
2025-05-15 13:56 ` [PATCH v2 4/5] ata: libata-eh: Rename no_dipm variable to be more clear Niklas Cassel
2025-05-15 13:56 ` [PATCH v2 5/5] ata: libata-eh: Keep DIPM disabled while modifying the allowed LPM states Niklas Cassel
2025-05-20  4:36 ` [PATCH v2 0/5] ata_eh_set_lpm() cleanups Mikko Juhani Korhonen
2025-05-20  9:33   ` Niklas Cassel
2025-05-23 14:47     ` Mikko Juhani Korhonen
2025-05-20  9:37 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250515135622.720623-7-cassel@kernel.org \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mjkorhon@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.