From: Kees Cook <kees@kernel.org>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: Shung-Hsi Yu <shung-hsi.yu@suse.com>,
bpf@vger.kernel.org, linux-mm@kvack.org,
Andrii Nakryiko <andrii@kernel.org>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Uladzislau Rezki <urezki@gmail.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
regressions@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Subject: Re: [REGRESSION] bpf verifier slowdown due to vrealloc() change since 6.15-rc6
Date: Thu, 15 May 2025 14:36:19 -0700 [thread overview]
Message-ID: <202505151435.ECC98E09@keescook> (raw)
In-Reply-To: <c36245a48149a12180ec710c65d317a12cdfa020.camel@gmail.com>
On Thu, May 15, 2025 at 11:31:09AM -0700, Eduard Zingerman wrote:
> On Thu, 2025-05-15 at 08:47 -0700, Kees Cook wrote:
> > On Thu, May 15, 2025 at 09:12:25PM +0800, Shung-Hsi Yu wrote:
> > > Bisect was done by Pawan and got to commit a0309faf1cb0 "mm: vmalloc:
> > > support more granular vrealloc() sizing"[2]. To further zoom in the
> >
> > Can you try this patch? It's a clear bug fix, but if it doesn't improve
> > things, I have another idea to rearrange the memset.
>
> I tried this patch on top of the commit 82f2b0b97b36 ("Linux 6.15-rc6").
> W/o the patch I observe the slowdown, test times out after 120 seconds,
> with the patch test finishes in 3 seconds.
Well that's pretty definitive! Thank you! I'll send out a properly
formatted patch. May I add your Tested-by?
--
Kees Cook
next prev parent reply other threads:[~2025-05-15 21:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 13:12 [REGRESSION] bpf verifier slowdown due to vrealloc() change since 6.15-rc6 Shung-Hsi Yu
2025-05-15 14:51 ` Kees Cook
2025-05-15 16:51 ` Kees Cook
2025-05-15 17:18 ` Pawan Gupta
2025-05-15 17:41 ` Kees Cook
2025-05-15 17:52 ` Pawan Gupta
2025-05-15 20:26 ` Pawan Gupta
2025-05-15 17:53 ` Andrii Nakryiko
2025-05-15 18:24 ` Kees Cook
2025-05-15 18:50 ` Eduard Zingerman
2025-05-15 15:47 ` Kees Cook
2025-05-15 15:53 ` Kees Cook
2025-05-15 15:55 ` Andrii Nakryiko
2025-05-15 16:01 ` Kees Cook
2025-05-15 18:31 ` Eduard Zingerman
2025-05-15 21:36 ` Kees Cook [this message]
2025-05-15 21:39 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505151435.ECC98E09@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ihor.solodrai@linux.dev \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=regressions@lists.linux.dev \
--cc=shung-hsi.yu@suse.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.