From: Halil Pasic <pasic@linux.ibm.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH] s390x: Fix leak in machine_set_loadparm
Date: Thu, 15 May 2025 14:51:29 +0200 [thread overview]
Message-ID: <20250515145129.4182bcca.pasic@linux.ibm.com> (raw)
In-Reply-To: <20250509174938.25935-1-farosas@suse.de>
On Fri, 9 May 2025 14:49:38 -0300
Fabiano Rosas <farosas@suse.de> wrote:
> ASAN spotted a leaking string in machine_set_loadparm():
>
> Direct leak of 9 byte(s) in 1 object(s) allocated from:
> #0 0x560ffb5bb379 in malloc ../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3
> #1 0x7f1aca926518 in g_malloc ../glib/gmem.c:106
> #2 0x7f1aca94113e in g_strdup ../glib/gstrfuncs.c:364
> #3 0x560ffc8afbf9 in qobject_input_type_str ../qapi/qobject-input-visitor.c:542:12
> #4 0x560ffc8a80ff in visit_type_str ../qapi/qapi-visit-core.c:349:10
> #5 0x560ffbe6053a in machine_set_loadparm ../hw/s390x/s390-virtio-ccw.c:802:10
> #6 0x560ffc0c5e52 in object_property_set ../qom/object.c:1450:5
> #7 0x560ffc0d4175 in object_property_set_qobject ../qom/qom-qobject.c:28:10
> #8 0x560ffc0c6004 in object_property_set_str ../qom/object.c:1458:15
> #9 0x560ffbe2ae60 in update_machine_ipl_properties ../hw/s390x/ipl.c:569:9
> #10 0x560ffbe2aa65 in s390_ipl_update_diag308 ../hw/s390x/ipl.c:594:5
> #11 0x560ffbdee132 in handle_diag_308 ../target/s390x/diag.c:147:9
> #12 0x560ffbebb956 in helper_diag ../target/s390x/tcg/misc_helper.c:137:9
> #13 0x7f1a3c51c730 (/memfd:tcg-jit (deleted)+0x39730)
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
prev parent reply other threads:[~2025-05-15 12:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 17:49 [PATCH] s390x: Fix leak in machine_set_loadparm Fabiano Rosas
2025-05-09 18:00 ` Thomas Huth
2025-05-12 14:07 ` Philippe Mathieu-Daudé
2025-05-12 14:13 ` Philippe Mathieu-Daudé
2025-05-12 15:37 ` Fabiano Rosas
2025-06-24 6:28 ` Thomas Huth
2025-06-24 12:34 ` Fabiano Rosas
2025-06-25 9:03 ` Kevin Wolf
2025-05-15 12:51 ` Halil Pasic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515145129.4182bcca.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.