From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [v4 PATCH 00/11] crypto: Add partial block API and hmac to ahash
Date: Thu, 15 May 2025 12:35:29 -0700 [thread overview]
Message-ID: <20250515193529.GJ1411@quark> (raw)
In-Reply-To: <cover.1747288315.git.herbert@gondor.apana.org.au>
On Thu, May 15, 2025 at 01:54:30PM +0800, Herbert Xu wrote:
> v4 switches the name of the hmac shash and ahash instances. The
> ahash instance will bear the hmac name while shash gets the driver
> name of hmac-shash.
That seems backwards. The shash one should be the regular one and ahash should
be special.
> A new test has been added to testmgr to ensure that all implementations
> of a given algorithm use the same export format.
Still lacks any explanation for why this even matters.
> crypto/ahash.c | 572 ++++++++++++++++-----------------
> crypto/algapi.c | 8 +-
> crypto/hmac.c | 392 +++++++++++++++++++---
> crypto/shash.c | 46 ++-
> crypto/testmgr.c | 134 ++++++--
> crypto/testmgr.h | 2 +
> include/crypto/algapi.h | 12 +-
> include/crypto/hash.h | 73 ++---
> include/crypto/internal/hash.h | 66 ++++
> 9 files changed, 883 insertions(+), 422 deletions(-)
>
> --
> 2.39.5
As usual, missing a base-commit. (Use the --base option to 'git format-patch')
- Eric
next prev parent reply other threads:[~2025-05-15 19:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 5:54 [v4 PATCH 00/11] crypto: Add partial block API and hmac to ahash Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 01/11] crypto: hash - Move core export and import into internel/hash.h Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 02/11] crypto: hash - Add export_core and import_core hooks Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 03/11] crypto: ahash - Handle partial blocks in API Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 04/11] crypto: hmac - Zero shash desc in setkey Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 05/11] crypto: hmac - Add export_core and import_core Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 06/11] crypto: shash - Set reqsize in shash_alg Herbert Xu
2025-05-15 19:32 ` Eric Biggers
2025-05-15 5:54 ` [v4 PATCH 07/11] crypto: algapi - Add driver template support to crypto_inst_setname Herbert Xu
2025-05-15 19:33 ` Eric Biggers
2025-05-15 5:54 ` [v4 PATCH 08/11] crypto: testmgr - Ignore EEXIST on shash allocation Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 09/11] crypto: hmac - Add ahash support Herbert Xu
2025-05-15 5:54 ` [v4 PATCH 10/11] crypto: testmgr - Use ahash for generic tfm Herbert Xu
2025-05-15 19:30 ` Eric Biggers
2025-05-15 5:54 ` [v4 PATCH 11/11] crypto: testmgr - Add hash export format testing Herbert Xu
2025-05-15 19:35 ` Eric Biggers [this message]
2025-05-16 9:23 ` [v4 PATCH 00/11] crypto: Add partial block API and hmac to ahash Herbert Xu
2025-05-16 16:43 ` Eric Biggers
2025-05-17 0:45 ` Herbert Xu
2025-05-17 1:17 ` Eric Biggers
2025-05-17 1:25 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515193529.GJ1411@quark \
--to=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.