Re: [PATCH net-next] net: let lockdep compare instance locks

[Jakub Kicinski <kuba@kernel.org>]

On Thu, 15 May 2025 18:49:07 -0700 Kuniyuki Iwashima wrote:
> > +#ifdef CONFIG_DEBUG_NET_SMALL_RTNL
> > +	/* It's okay to use per-netns rtnl_lock if devices share netns */
> > +	if (net_eq(dev_net(dev_a), dev_net(dev_b)) &&
> > +	    lockdep_rtnl_net_is_held(dev_net(dev_a)))  
> 
> Do we need
> 
>   !from_cleanup_net()
> 
> before lockdep_rtnl_net_is_held() ?
> 
> __rtnl_net_lock() is not held in ops_exit_rtnl_list() and
> default_device_exit_batch() when calling unregister_netdevice_many().

Or do we need

  if (from_cleanup_net())
  	return -1;

?
Is the thinking that once the big rtnl lock disappears in cleanup_net
the devices are safe to destroy without any locking because there can't
be any live users trying to access them?