Re: [meta-arago][scarthgap/master][PATCH] meta-arago-test: Add optee-test, strongswan, and libgpiod-tools to image

[Denys Dmytriyenko <denis@denix.org>]

On Thu, May 15, 2025 at 04:53:11PM -0500, Andrew Davis wrote:
> On 5/15/25 3:08 PM, Denys Dmytriyenko wrote:
> >On Thu, May 15, 2025 at 02:29:15PM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> >>On 5/13/25 12:20 PM, Denys Dmytriyenko wrote:
> >>>On Thu, May 01, 2025 at 09:43:57AM -0500, Andrew Davis via lists.yoctoproject.org wrote:
> >>>>These packages are used by ltp-ddt and the test framework. These are
> >>>>added to the default Arago images, but when doing upstream testing with
> >>>>Poky these packages are missing. Add these to the base testing layer.
> >>>>
> >>>>Signed-off-by: Andrew Davis <afd@ti.com>
> >>>>---
> >>>>  meta-arago-test/recipes-core/packagegroups/ti-test.bb        | 2 ++
> >>>>  meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt_20250130.bb | 1 +
> >>>>  2 files changed, 3 insertions(+)
> >>>>
> >>>>diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb
> >>>>index c8eaf266..e387b978 100644
> >>>>--- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb
> >>>>+++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb
> >>>>@@ -41,6 +41,7 @@ TI_TEST_BASE = "\
> >>>>      nbench-byte \
> >>>>      netperf \
> >>>>      openntpd \
> >>>>+    optee-test \
> >>>
> >>>Should this be conditional on whether OPTEE is used for the platform?
> >>>Like it is done here:
> >>>https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb#n58
> >>>
> >>
> >>Good catch, this does need to be conditional or AM335x (the only plat we
> >>have without OP-TEE) will break, will update and resend.
> >
> >The other legacy platform that doesn't use OPTEE is OMAP-L138.
> >
> >Also, if you recall, only HS variants of AM437x and AM57x use OP-TEE, not GP.
> >
> 
> Sure but these still have valid platform targets in OP-TEE, so the building
> the optee-test package should still work; there are no target names for AM335
> (and L138) so they would cause an issue when building the OP-TEE dependency.

Those GP platforms don't set any valid OP-TEE targets, so the build will still 
fail.


> Side thought, I wonder if having an "optee" MACHINE_FEATURE would be a better
> solution than checking OPTEEOUTPUTMACHINE as done in packagegroup-arago-base.bb
> (which shouldn't that be OPTEEMACHINE?)

Ah, indeed:
https://git.yoctoproject.org/meta-ti/commit/?id=0942b58dab47920f6d5661017720f3e5589389d4

Though OPTEEMACHINE is either "ti-am57xx" or "ti-dra7xx" or "ti-am43xx" for 
legacy platforms and "k3-*" for K3 platforms (though all K3 use OPTEE).

Can probably simply check if OPTEEMACHINE is defined and not empty...


> Andrew
> 
> >
> >>Thanks,
> >>Andrew
> >>
> >>>
> >>>>      pcitest \
> >>>>      perf \
> >>>>      powertop \
> >>>>@@ -53,6 +54,7 @@ TI_TEST_BASE = "\
> >>>>      stream \
> >>>>      stress \
> >>>>      stress-ng \
> >>>>+    strongswan \
> >>>>      tcpdump \
> >>>>      v4l-utils \
> >>>>      yavta \
> >>>>diff --git a/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt_20250130.bb b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt_20250130.bb
> >>>>index 1950ffe9..2c65e851 100644
> >>>>--- a/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt_20250130.bb
> >>>>+++ b/meta-arago-test/recipes-devtools/ltp-ddt/ltp-ddt_20250130.bb
> >>>>@@ -33,6 +33,7 @@ RDEPENDS:${PN} += "\
> >>>>      pm-qa \
> >>>>      serialcheck \
> >>>>      memtester \
> >>>>+    libgpiod-tools \
> >>>>  "
> >>>>  do_install:prepend() {
> >>>>-- 
> >>>>2.39.2