From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v5 3/6] KVM: add kvm_lock_all_vcpus and kvm_trylock_all_vcpus
Date: Fri, 16 May 2025 06:20:11 +0800 [thread overview]
Message-ID: <202505160516.x1btCT1R-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250512180407.659015-4-mlevitsk@redhat.com>
References: <20250512180407.659015-4-mlevitsk@redhat.com>
TO: Maxim Levitsky <mlevitsk@redhat.com>
TO: kvm@vger.kernel.org
CC: Suzuki K Poulose <suzuki.poulose@arm.com>
CC: Jing Zhang <jingzhangos@google.com>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: Sebastian Ott <sebott@redhat.com>
CC: Shusen Li <lishusen2@huawei.com>
CC: Waiman Long <longman@redhat.com>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: linux-arm-kernel@lists.infradead.org
CC: Bjorn Helgaas <helgaas@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: Anup Patel <anup@brainfault.org>
CC: Will Deacon <will@kernel.org>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: Alexander Potapenko <glider@google.com>
CC: kvmarm@lists.linux.dev
CC: Keisuke Nishimura <keisuke.nishimura@inria.fr>
CC: Zenghui Yu <yuzenghui@huawei.com>
CC: Peter Zijlstra <peterz@infradead.org>
CC: Atish Patra <atishp@atishpatra.org>
CC: Joey Gouly <joey.gouly@arm.com>
CC: x86@kernel.org
CC: Marc Zyngier <maz@kernel.org>
CC: Sean Christopherson <seanjc@google.com>
CC: Andre Przywara <andre.przywara@arm.com>
CC: Kunkun Jiang <jiangkunkun@huawei.com>
CC: linux-riscv@lists.infradead.org
CC: Randy Dunlap <rdunlap@infradead.org>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Boqun Feng <boqun.feng@gmail.com>
Hi Maxim,
kernel test robot noticed the following build warnings:
[auto build test WARNING on kvmarm/next]
[also build test WARNING on kvm/queue kvm/next tip/locking/core linus/master v6.15-rc6 next-20250515]
[cannot apply to kvm/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Maxim-Levitsky/locking-mutex-implement-mutex_trylock_nested/20250513-021708
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
patch link: https://lore.kernel.org/r/20250512180407.659015-4-mlevitsk%40redhat.com
patch subject: [PATCH v5 3/6] KVM: add kvm_lock_all_vcpus and kvm_trylock_all_vcpus
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: x86_64-randconfig-161-20250515 (https://download.01.org/0day-ci/archive/20250516/202505160516.x1btCT1R-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202505160516.x1btCT1R-lkp@intel.com/
New smatch warnings:
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1380 kvm_trylock_all_vcpus() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1386 kvm_trylock_all_vcpus() warn: iterator 'j' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1403 kvm_lock_all_vcpus() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1411 kvm_lock_all_vcpus() warn: iterator 'j' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1427 kvm_unlock_all_vcpus() warn: iterator 'i' not incremented
Old smatch warnings:
arch/x86/kvm/../../../virt/kvm/kvm_main.c:285 kvm_make_all_cpus_request() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:489 kvm_destroy_vcpus() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1723 kvm_commit_memory_region() error: we previously assumed 'old' could be null (see line 1716)
arch/x86/kvm/../../../virt/kvm/kvm_main.c:1725 kvm_commit_memory_region() error: we previously assumed 'new' could be null (see line 1717)
include/linux/kvm_host.h:1010 kvm_get_vcpu_by_id() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:4963 kvm_vm_ioctl_reset_dirty_pages() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:6100 kvm_get_stat_per_vcpu() warn: iterator 'i' not incremented
arch/x86/kvm/../../../virt/kvm/kvm_main.c:6111 kvm_clear_stat_per_vcpu() warn: iterator 'i' not incremented
vim +/i +1380 arch/x86/kvm/../../../virt/kvm/kvm_main.c
6aa8b732ca01c3 drivers/kvm/kvm_main.c Avi Kivity 2006-12-10 1372
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1373 int kvm_trylock_all_vcpus(struct kvm *kvm)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1374 {
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1375 struct kvm_vcpu *vcpu;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1376 unsigned long i, j;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1377
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1378 lockdep_assert_held(&kvm->lock);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1379
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1380 kvm_for_each_vcpu(i, vcpu, kvm)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1381 if (!mutex_trylock_nest_lock(&vcpu->mutex, &kvm->lock))
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1382 goto out_unlock;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1383 return 0;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1384
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1385 out_unlock:
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1386 kvm_for_each_vcpu(j, vcpu, kvm) {
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1387 if (i == j)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1388 break;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1389 mutex_unlock(&vcpu->mutex);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1390 }
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1391 return -EINTR;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1392 }
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1393 EXPORT_SYMBOL_GPL(kvm_trylock_all_vcpus);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1394
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1395 int kvm_lock_all_vcpus(struct kvm *kvm)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1396 {
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1397 struct kvm_vcpu *vcpu;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1398 unsigned long i, j;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1399 int r;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1400
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1401 lockdep_assert_held(&kvm->lock);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1402
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1403 kvm_for_each_vcpu(i, vcpu, kvm) {
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1404 r = mutex_lock_killable_nest_lock(&vcpu->mutex, &kvm->lock);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1405 if (r)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1406 goto out_unlock;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1407 }
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1408 return 0;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1409
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1410 out_unlock:
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1411 kvm_for_each_vcpu(j, vcpu, kvm) {
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1412 if (i == j)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1413 break;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1414 mutex_unlock(&vcpu->mutex);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1415 }
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1416 return r;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1417 }
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1418 EXPORT_SYMBOL_GPL(kvm_lock_all_vcpus);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1419
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1420 void kvm_unlock_all_vcpus(struct kvm *kvm)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1421 {
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1422 struct kvm_vcpu *vcpu;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1423 unsigned long i;
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1424
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1425 lockdep_assert_held(&kvm->lock);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1426
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1427 kvm_for_each_vcpu(i, vcpu, kvm)
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1428 mutex_unlock(&vcpu->mutex);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1429 }
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1430 EXPORT_SYMBOL_GPL(kvm_unlock_all_vcpus);
fcd6700857d5e9 virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1431
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-05-15 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 22:20 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-05-12 18:04 [PATCH v5 0/6] KVM: lockdep improvements Maxim Levitsky
2025-05-12 18:04 ` [PATCH v5 3/6] KVM: add kvm_lock_all_vcpus and kvm_trylock_all_vcpus Maxim Levitsky
2025-05-12 18:04 ` Maxim Levitsky
2025-05-12 18:04 ` Maxim Levitsky
2025-05-14 9:33 ` Marc Zyngier
2025-05-14 9:33 ` Marc Zyngier
2025-05-14 9:33 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202505160516.x1btCT1R-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.