From: Jakub Kicinski <kuba@kernel.org>
To: weishangjuan@eswincomputing.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, richardcochran@gmail.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, p.zabel@pengutronix.de,
yong.liang.choong@linux.intel.com, rmk+kernel@armlinux.org.uk,
jszhang@kernel.org, inochiama@gmail.com, jan.petrous@oss.nxp.com,
dfustini@tenstorrent.com, 0x1207@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, lizhi2@eswincomputing.com
Subject: Re: [PATCH v1 2/2] ethernet: eswin: Add eic7700 ethernet driver
Date: Fri, 16 May 2025 07:32:17 -0700 [thread overview]
Message-ID: <20250516073217.115fc170@kernel.org> (raw)
In-Reply-To: <20250516011130.818-1-weishangjuan@eswincomputing.com>
On Fri, 16 May 2025 09:11:28 +0800 weishangjuan@eswincomputing.com
wrote:
> + dwc_priv->clk_tx = devm_clk_get(&pdev->dev, "tx");
> + if (IS_ERR(plat_dat->pclk)) {
you're checking the wrong pointer here
> + dev_err(&pdev->dev, "tx clock not found.\n");
> + return PTR_ERR(dwc_priv->clk_tx);
--
pw-bot: cr
next prev parent reply other threads:[~2025-05-16 15:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 1:08 [PATCH v1 0/2] Add driver support for Eswin eic7700 SoC ethernet controller weishangjuan
2025-05-16 1:10 ` [PATCH v1 1/2] ethernet: eswin: Document for eic7700 SoC weishangjuan
2025-05-16 2:23 ` Rob Herring (Arm)
2025-05-16 2:23 ` Rob Herring (Arm)
2025-05-16 13:19 ` Krzysztof Kozlowski
2025-05-18 1:07 ` Inochi Amaoto
2025-05-18 22:38 ` Andrew Lunn
2025-05-26 5:41 ` Bo Gan
2025-05-16 1:11 ` [PATCH v1 2/2] ethernet: eswin: Add eic7700 ethernet driver weishangjuan
2025-05-16 14:32 ` Jakub Kicinski [this message]
2025-05-17 14:11 ` Simon Horman
2025-05-18 1:12 ` Inochi Amaoto
2025-05-18 22:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250516073217.115fc170@kernel.org \
--to=kuba@kernel.org \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lizhi2@eswincomputing.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=weishangjuan@eswincomputing.com \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.