diff for duplicates of <20250516084320.66998caf@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 214fb1e..d34d82a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,20 +1,36 @@ -On Fri, 16 May 2025 11:46:57 +0800 Jinjian Song wrote: -> >Module parameters are discouraged, they are pretty poor as an API since -> >they apply to all devices in the system. Can you describe what "frg" -> >and "bat" are ? One of the existing APIs likely covers them. -> >Please also describe the scope (are they per netdev or some sort of -> >device level params)? -> -> MTK t7xx data plane hardware use BAT (Buffer Address Table) and FRG (Fragment) BAT -> to describle and manager RX buffer, these buffers will apply for a fixed size after -> the driver probe, and accompany the life cycle of the driver. -> -> On some platforms, especially those that use swiotlb to manager buffers, without -> changing the buffer pool provided by swiotlb, it's needed to adjust the buffers -> used by the driver to meet the requirements. -> So parameterize these buffers applicable to the MTK t7xx driver to facilitate -> different platforms to work with different configurations. +>On Fri, 16 May 2025 11:46:57 +0800 Jinjian Song wrote: +>> >Module parameters are discouraged, they are pretty poor as an API since +>> >they apply to all devices in the system. Can you describe what "frg" +>> >and "bat" are ? One of the existing APIs likely covers them. +>> >Please also describe the scope (are they per netdev or some sort of +>> >device level params)? +>> +>> MTK t7xx data plane hardware use BAT (Buffer Address Table) and FRG (Fragment) BAT +>> to describle and manager RX buffer, these buffers will apply for a fixed size after +>> the driver probe, and accompany the life cycle of the driver. +>> +>> On some platforms, especially those that use swiotlb to manager buffers, without +>> changing the buffer pool provided by swiotlb, it's needed to adjust the buffers +>> used by the driver to meet the requirements. +>> So parameterize these buffers applicable to the MTK t7xx driver to facilitate +>> different platforms to work with different configurations. +> +>Have you looked at +>https://docs.kernel.org/networking/ethtool-netlink.html#rings-set +>? +> -Have you looked at -https://docs.kernel.org/networking/ethtool-netlink.html#rings-set -? +Hi Jakub, + Thanks, I've just learned this content. + I think ETHTOOL_STRINGPARAM is a good summary of the ring parameters and can +be referred to and applied to WWAN. However, it seemes that this can't be configured +when the driver is loaded and requires an application through ioctrl. In addition, +directly using this parameter can't well correspond to the multiple buffer representing +BAT in the t7xx driver. + + If it's not feasible to directly add parameters for configuring this RX buffer(BAT/FAG) to +the mtk_t7xx driver, would it be allowed to add aparameter for a default configuration +ratio (1/2, 1/4)? Or is it not recommended to use driver parameters for mtk_t7xx driver. + +Thanks, +Best Regards. diff --git a/a/content_digest b/N1/content_digest index bddd2f3..e356e21 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\020250514104728.10869-1-jinjian.song@fibocom.com\0" "ref\020250515180858.2568d930@kernel.org\0" - "From\0Jakub Kicinski <kuba@kernel.org>\0" + "From\0Jinjian Song <jinjian.song@fibocom.com>\0" "Subject\0Re: [net-next v1] net: wwan: t7xx: Parameterize data plane RX BAT and FAG count\0" - "Date\0Fri, 16 May 2025 08:43:20 -0700\0" - "To\0Jinjian Song <jinjian.song@fibocom.com>\0" + "Date\0Tue, 20 May 2025 10:59:34 +0800\0" + "To\0kuba@kernel.org\0" "Cc\0andrew+netdev@lunn.ch" angelogioacchino.delregno@collabora.com chandrashekar.devegowda@intel.com @@ -15,6 +15,7 @@ haijun.liu@mediatek.com helgaas@kernel.org horms@kernel.org + jinjian.song@fibocom.com johannes@sipsolutions.net korneld@google.com linux-arm-kernel@lists.infradead.org @@ -31,25 +32,41 @@ " ryazanov.s.a@gmail.com\0" "\00:1\0" "b\0" - "On Fri, 16 May 2025 11:46:57 +0800 Jinjian Song wrote:\n" - "> >Module parameters are discouraged, they are pretty poor as an API since\n" - "> >they apply to all devices in the system. Can you describe what \"frg\"\n" - "> >and \"bat\" are ? One of the existing APIs likely covers them.\n" - "> >Please also describe the scope (are they per netdev or some sort of\n" - "> >device level params)? \n" - "> \n" - "> MTK t7xx data plane hardware use BAT (Buffer Address Table) and FRG (Fragment) BAT\n" - "> to describle and manager RX buffer, these buffers will apply for a fixed size after\n" - "> the driver probe, and accompany the life cycle of the driver.\n" - "> \n" - "> On some platforms, especially those that use swiotlb to manager buffers, without\n" - "> changing the buffer pool provided by swiotlb, it's needed to adjust the buffers\n" - "> used by the driver to meet the requirements.\n" - "> So parameterize these buffers applicable to the MTK t7xx driver to facilitate\n" - "> different platforms to work with different configurations. \n" + ">On Fri, 16 May 2025 11:46:57 +0800 Jinjian Song wrote:\n" + ">> >Module parameters are discouraged, they are pretty poor as an API since\n" + ">> >they apply to all devices in the system. Can you describe what \"frg\"\n" + ">> >and \"bat\" are ? One of the existing APIs likely covers them.\n" + ">> >Please also describe the scope (are they per netdev or some sort of\n" + ">> >device level params)? \n" + ">> \n" + ">> MTK t7xx data plane hardware use BAT (Buffer Address Table) and FRG (Fragment) BAT\n" + ">> to describle and manager RX buffer, these buffers will apply for a fixed size after\n" + ">> the driver probe, and accompany the life cycle of the driver.\n" + ">> \n" + ">> On some platforms, especially those that use swiotlb to manager buffers, without\n" + ">> changing the buffer pool provided by swiotlb, it's needed to adjust the buffers\n" + ">> used by the driver to meet the requirements.\n" + ">> So parameterize these buffers applicable to the MTK t7xx driver to facilitate\n" + ">> different platforms to work with different configurations. \n" + ">\n" + ">Have you looked at\n" + ">https://docs.kernel.org/networking/ethtool-netlink.html#rings-set \n" + ">?\n" + ">\n" "\n" - "Have you looked at\n" - "https://docs.kernel.org/networking/ethtool-netlink.html#rings-set \n" - ? + "Hi Jakub,\n" + " Thanks, I've just learned this content.\n" + " I think ETHTOOL_STRINGPARAM is a good summary of the ring parameters and can\n" + "be referred to and applied to WWAN. However, it seemes that this can't be configured\n" + "when the driver is loaded and requires an application through ioctrl. In addition,\n" + "directly using this parameter can't well correspond to the multiple buffer representing\n" + "BAT in the t7xx driver.\n" + "\n" + " If it's not feasible to directly add parameters for configuring this RX buffer(BAT/FAG) to \n" + "the mtk_t7xx driver, would it be allowed to add aparameter for a default configuration \n" + "ratio (1/2, 1/4)? Or is it not recommended to use driver parameters for mtk_t7xx driver.\n" + "\n" + "Thanks,\n" + Best Regards. -cc226f7498a2e7ab89907b7f56d979f5f9415706b6b9719dbdc9078686922a07 +7f6d8646843296a65e25a87862b899e58632d370a7db05d93aaae9c07b8d7666
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.