From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 566F7C3ABD8 for ; Fri, 16 May 2025 09:44:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1F02F412C2; Fri, 16 May 2025 09:44:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id WlH8EyoLFuwg; Fri, 16 May 2025 09:44:52 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 996374179B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1747388692; bh=zeDVGallpyx86MVPYW2oyrxQ4AA6H8+Id3X11NOAxzw=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=5riyDuxatzXvkfZ1ik6p3DVgFWiZt3ZszBn6+PdsY8frnZO1VIHUzN4w2l1x3WFob 6UOF+DQ1oYpy0Y+VveXclLJKZk7HTyZySKLf4ZbbUCRv6xUtP22SAEDbqSLP6iHNVW YYTCqO3rwJjKFQO0UbUtdmBDdibsKsm4hiyCsMtdDvj0Ih2oTrGn6N1YRWGmza1rPF rF43wGn78JpAU/gS77LAaEvYvXpt1xwWl8/qGyvvwdHfN924DfJ+G81j2Sc2UC7hVO 8FipptGkDS6nvqKd1FX2opPMwE7hHDCDI/azoaMbWl+oYqtNJP/BPKtlcffneBWPcJ fWpY+GSuvnlNA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 996374179B; Fri, 16 May 2025 09:44:52 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 262531AB for ; Fri, 16 May 2025 09:44:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 231834224A for ; Fri, 16 May 2025 09:44:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id HyKwm-V59Wkj for ; Fri, 16 May 2025 09:44:50 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31; helo=sea.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 993CC42210 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 993CC42210 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by smtp2.osuosl.org (Postfix) with ESMTPS id 993CC42210 for ; Fri, 16 May 2025 09:44:50 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5DAAF49E95; Fri, 16 May 2025 09:44:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A009EC4CEE4; Fri, 16 May 2025 09:44:47 +0000 (UTC) Date: Fri, 16 May 2025 10:44:45 +0100 From: Simon Horman To: Faizal Rahim Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksandr Loktionov , Chwee-Lin Choong Message-ID: <20250516094445.GL1898636@horms.kernel.org> References: <20250514042945.2685273-1-faizal.abdul.rahim@linux.intel.com> <20250514042945.2685273-5-faizal.abdul.rahim@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250514042945.2685273-5-faizal.abdul.rahim@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747388690; bh=NgSUy9/TUIWcSc5wRvHR2evt/6x18KOmHbwGmpmLoD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbioaSo5jdwYLplqu4qjleDpg7E3MRGdBCFcOZCA1NAgPou9Z9VFkUijLpN6mdwU2 aiilv3a8Eb96BbiSiPsJp8ehkhIPXS0JVTRlopijJuhJCz4SCQYf+P7ToBRkuYn2Gn kyDZtN4UAPcb3txZLn7laY1bN8cHh3H7aIPQ0RlREFXP7cXvlAgLovlMI+M9pmH9Nw VMJYvJa3TdiFngC6yGxVwJyyZpC5b257KQ52zyt9Uly69UavCUCWWIR4g8oG5K+yyk 6gtAtKYpvCJU33WoGpsIr1d9YU8KG/AW8LKrW3PSFCme21/PX99QGJUnUqSOZ/YHDF 8DqK3J2YdYxPA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IbioaSo5 Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 4/8] igc: assign highest TX queue number as highest priority in mqprio X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, May 14, 2025 at 12:29:41AM -0400, Faizal Rahim wrote: > Previously, TX arbitration prioritized queues based on the TC they were > mapped to. A queue mapped to TC 3 had higher priority than one mapped to > TC 0. > > To improve code reuse for upcoming patches and align with typical NIC > behavior, this patch updates the logic to prioritize higher queue numbers > when mqprio is used. As a result, queue 0 becomes the lowest priority and > queue 3 becomes the highest. > > This patch also introduces igc_tsn_is_tc_to_queue_priority_ordered() to > preserve the original TC-based priority rule and reject configurations > where a higher TC maps to a lower queue offset. > > Signed-off-by: Faizal Rahim Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C751D18C008; Fri, 16 May 2025 09:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747388690; cv=none; b=kjO61Rr08ElnH8AHOKZQ0wWJGZgxvkH8o6NEnE5LDucRiyjaHpRiJWTrXrOInpvT3/W99n5lBQ7hmeny5MlO8OXH3fKy0oJlLQJbu9jvR1WuMAYj1Aaf8RBqaFuI/wyh9vjQHOrPe4mm7oa/2pohyNU73+EKaInVsYamJrlx0Iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747388690; c=relaxed/simple; bh=NgSUy9/TUIWcSc5wRvHR2evt/6x18KOmHbwGmpmLoD0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t8On2Uhn6uefclmm3TtlqYw0SxZRoAvqTo/1rI/Qv0+99iFccZDvMPWzmh7PCqbGWZF7GJty2s/zH0yWQbTpXe6hQMKFS/jonq+Wt4LXVBsohQe2/UnVkHPuiC7ibLpv/YreRskR48fuwCS+5GnpYFoYk0ayO5PbnItkPvgkWkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IbioaSo5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IbioaSo5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A009EC4CEE4; Fri, 16 May 2025 09:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747388690; bh=NgSUy9/TUIWcSc5wRvHR2evt/6x18KOmHbwGmpmLoD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IbioaSo5jdwYLplqu4qjleDpg7E3MRGdBCFcOZCA1NAgPou9Z9VFkUijLpN6mdwU2 aiilv3a8Eb96BbiSiPsJp8ehkhIPXS0JVTRlopijJuhJCz4SCQYf+P7ToBRkuYn2Gn kyDZtN4UAPcb3txZLn7laY1bN8cHh3H7aIPQ0RlREFXP7cXvlAgLovlMI+M9pmH9Nw VMJYvJa3TdiFngC6yGxVwJyyZpC5b257KQ52zyt9Uly69UavCUCWWIR4g8oG5K+yyk 6gtAtKYpvCJU33WoGpsIr1d9YU8KG/AW8LKrW3PSFCme21/PX99QGJUnUqSOZ/YHDF 8DqK3J2YdYxPA== Date: Fri, 16 May 2025 10:44:45 +0100 From: Simon Horman To: Faizal Rahim Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksandr Loktionov , Chwee-Lin Choong Subject: Re: [PATCH iwl-next v2 4/8] igc: assign highest TX queue number as highest priority in mqprio Message-ID: <20250516094445.GL1898636@horms.kernel.org> References: <20250514042945.2685273-1-faizal.abdul.rahim@linux.intel.com> <20250514042945.2685273-5-faizal.abdul.rahim@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250514042945.2685273-5-faizal.abdul.rahim@linux.intel.com> On Wed, May 14, 2025 at 12:29:41AM -0400, Faizal Rahim wrote: > Previously, TX arbitration prioritized queues based on the TC they were > mapped to. A queue mapped to TC 3 had higher priority than one mapped to > TC 0. > > To improve code reuse for upcoming patches and align with typical NIC > behavior, this patch updates the logic to prioritize higher queue numbers > when mqprio is used. As a result, queue 0 becomes the lowest priority and > queue 3 becomes the highest. > > This patch also introduces igc_tsn_is_tc_to_queue_priority_ordered() to > preserve the original TC-based priority rule and reject configurations > where a higher TC maps to a lower queue offset. > > Signed-off-by: Faizal Rahim Reviewed-by: Simon Horman