All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Cherniaev Andrei <dungeonlords789@naver.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] boot/grub2/readme.txt: fix script
Date: Fri, 16 May 2025 11:19:40 +0200	[thread overview]
Message-ID: <20250516111940.55844cfd@windsurf> (raw)
In-Reply-To: <20250515144241.3082079-1-dungeonlords789@naver.com>

Hello,

On Thu, 15 May 2025 23:42:40 +0900
Cherniaev Andrei <dungeonlords789@naver.com> wrote:

> Fix regression of commit 552ba600eef0884bb7bf7f09a67cd66747d1efa8 Without `--show` loop_dev variable will be empty so script never works... Sorry, it was my mistake...

Thanks for your patch!

However, it lacks your Signed-off-by line, so we cannot merge it. Also,
could you wrap your commit message, and avoid "personal comments" like
"Sorry it was my mistake" ? Could you send a v2 with those issues fixed?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-05-16  9:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-15 14:42 [Buildroot] [PATCH] boot/grub2/readme.txt: fix script Cherniaev Andrei
2025-05-16  9:19 ` Thomas Petazzoni via buildroot [this message]
2025-05-16  9:35 ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2025-05-16 15:08 Cherniaev Andrei
2025-05-16 20:00 ` Peter Korsgaard
2025-05-31 16:53 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250516111940.55844cfd@windsurf \
    --to=buildroot@buildroot.org \
    --cc=dungeonlords789@naver.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.