From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C6B23182F for ; Fri, 16 May 2025 13:01:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747400469; cv=none; b=X2vD0BPEiKW0Gg2OGcPpd7prWLK9wOFufqxN7/8K6yxTDlgcN2kDupa+UA6WAXSA9En8BeHnFBTrlkmBEDBkKjkhu0T0vDoKGIjX8R0oFzzFUOWTUaHOYaMgLrnc+nQ3IIHpY3rI2WSdvDUWV7DRkCVfFiL+aVe4L1N+QnsBagA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747400469; c=relaxed/simple; bh=awE7T2c+cIQjoKD4W1ib2PjO78Tq0EHz3CnMvBSyb0Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LjqkL26Pv0/k3DUeNtqCoCQJV5dkkTLQ/ImTZcU8vcQAGKnPLzbOS8MexGFDWGcjHe0+vfwAlgLi0YzsC2Cdvx+dWE5IycfexHVFP+k7BoFR0grFwA54Ovr3DECHXOPFi11HKIcaLRwpi6ukwyV2Yw/GW5R7NMv97APjHz74eQo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0rOXletO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0rOXletO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22DB4C4CEE4; Fri, 16 May 2025 13:01:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1747400468; bh=awE7T2c+cIQjoKD4W1ib2PjO78Tq0EHz3CnMvBSyb0Y=; h=From:To:Cc:Subject:Date:Reply-to:From; b=0rOXletO2LKRB42h97vQhYe03fDhn9/bouJVwq6iZNycMhfv15GEmaWHHsV/syo0W E4d7UN0jH27Cnz8DHk0DrTBnWBdFQf5G/csy3V2RaOBCy/6FwmiXra2LbNSEco0i4o haz5r9xT08/haeWU+89TBvArjMa66qqaPvhIKRRw= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2025-37890: net_sched: hfsc: Fix a UAF vulnerability in class with netem as child qdisc Date: Fri, 16 May 2025 14:59:18 +0200 Message-ID: <2025051617-CVE-2025-37890-437b@gregkh> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3275; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=PfWHiGMF0nUOazxUsSZPNz+LCTkccH2alZrIlGivTiM=; b=owGbwMvMwCRo6H6F97bub03G02pJDBnqZkvvHV1e27JZx0ddYGdr/ebritODBdZPXVzF7chT3 SKazv6kI5aFQZCJQVZMkeXLNp6j+ysOKXoZ2p6GmcPKBDKEgYtTACbyuJVhwZ5NRxaJx5868O1W /fSG8MKXv19yvGCYX/H+k+WnbffvvL1SP5W1+Zv3592eKQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit From: Greg Kroah-Hartman Description =========== In the Linux kernel, the following vulnerability has been resolved: net_sched: hfsc: Fix a UAF vulnerability in class with netem as child qdisc As described in Gerrard's report [1], we have a UAF case when an hfsc class has a netem child qdisc. The crux of the issue is that hfsc is assuming that checking for cl->qdisc->q.qlen == 0 guarantees that it hasn't inserted the class in the vttree or eltree (which is not true for the netem duplicate case). This patch checks the n_active class variable to make sure that the code won't insert the class in the vttree or eltree twice, catering for the reentrant case. [1] https://lore.kernel.org/netdev/CAHcdcOm+03OD2j6R0=YHKqmy=VgJ8xEOKuP6c7mSgnp-TEJJbw@mail.gmail.com/ The Linux kernel CVE team has assigned CVE-2025-37890 to this issue. Affected and fixed versions =========================== Issue introduced in 5.0 with commit 37d9cf1a3ce35de3df6f7d209bfb1f50cf188cea and fixed in 5.15.182 with commit e3e949a39a91d1f829a4890e7dfe9417ac72e4d0 Issue introduced in 5.0 with commit 37d9cf1a3ce35de3df6f7d209bfb1f50cf188cea and fixed in 6.1.138 with commit 8df7d37d626430035b413b97cee18396b3450bef Issue introduced in 5.0 with commit 37d9cf1a3ce35de3df6f7d209bfb1f50cf188cea and fixed in 6.6.90 with commit 6082a87af4c52f58150d40dec1716011d871ac21 Issue introduced in 5.0 with commit 37d9cf1a3ce35de3df6f7d209bfb1f50cf188cea and fixed in 6.12.28 with commit 2e7093c7a8aba5d4f8809f271488e5babe75e202 Issue introduced in 5.0 with commit 37d9cf1a3ce35de3df6f7d209bfb1f50cf188cea and fixed in 6.14.6 with commit ac39fd4a757584d78ed062d4f6fd913f83bd98b5 Issue introduced in 5.0 with commit 37d9cf1a3ce35de3df6f7d209bfb1f50cf188cea and fixed in 6.15-rc5 with commit 141d34391abbb315d68556b7c67ad97885407547 Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2025-37890 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: net/sched/sch_hfsc.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/e3e949a39a91d1f829a4890e7dfe9417ac72e4d0 https://git.kernel.org/stable/c/8df7d37d626430035b413b97cee18396b3450bef https://git.kernel.org/stable/c/6082a87af4c52f58150d40dec1716011d871ac21 https://git.kernel.org/stable/c/2e7093c7a8aba5d4f8809f271488e5babe75e202 https://git.kernel.org/stable/c/ac39fd4a757584d78ed062d4f6fd913f83bd98b5 https://git.kernel.org/stable/c/141d34391abbb315d68556b7c67ad97885407547