From: Simon Horman <horms@kernel.org>
To: goralbaris <goralbaris@gmail.com>
Cc: allison.henderson@oracle.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-rdma@vger.kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH net-next v2] Replace strncpy with strscpy
Date: Sun, 18 May 2025 10:00:20 +0100 [thread overview]
Message-ID: <20250518090020.GA366906@horms.kernel.org> (raw)
In-Reply-To: <20250517181248.28913-1-goralbaris@gmail.com>
On Sat, May 17, 2025 at 09:12:48PM +0300, goralbaris wrote:
> Hi,
> Any news about this Patch?
Hi Baris,
I expect this patch floundered because it was not CCed to netdev.
In any case, there was a separate effort to address this problem.
- [PATCH v2] net: rds: Replace strncpy with strscpy in connection setup
by Shankari Anand
https://lore.kernel.org/netdev/20250426192113.47012-1-shankari.ak0208@gmail.com/
I would suggest that a successful patch should:
* Use the two-argument variant of strscpy_pad (see thread above)
* Include commentary in the commit message regarding
- Why strctpy* is preferred over strncpy (you already did that :).
- Why strscpy_pad is appropriate instead of strscpy
* CC all relevant parties, including netdev, the Netdev maintainers,
Shankari Anand and Allison Henderson
next prev parent reply other threads:[~2025-05-18 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 18:30 [PATCH] net: rds transform strncpy to strscpy Baris Can Goral
2025-04-08 18:22 ` Simon Horman
2025-04-08 21:21 ` [PATCH net-next v2] Replace strncpy with strscpy Baris Can Goral
2025-05-17 18:12 ` goralbaris
2025-05-18 9:00 ` Simon Horman [this message]
2025-05-18 19:53 ` [PATCH v3 net-next: rds] replace strncpy with strscpy_pad goralbaris
2025-05-19 7:01 ` Michal Swiatkowski
2025-05-19 12:51 ` [PATCH v4 " Baris Can Goral
2025-05-19 21:15 ` Allison Henderson
2025-05-20 16:23 ` [PATCH v5 " Baris Can Goral
2025-05-20 21:13 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250518090020.GA366906@horms.kernel.org \
--to=horms@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=goralbaris@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.