diff for duplicates of <202505181116.RhlCb75I-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index d4d66ac..946514d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,27 +1,46 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +In-Reply-To: <20250516150010.61641-1-anna@kernel.org> +References: <20250516150010.61641-1-anna@kernel.org> +TO: Anna Schumaker <anna@kernel.org> +TO: linux-nfs@vger.kernel.org +TO: trond.myklebust@hammerspace.com +CC: anna@kernel.org + Hi Anna, kernel test robot noticed the following build warnings: +[auto build test WARNING on trondmy-nfs/linux-next] +[also build test WARNING on linus/master v6.15-rc6 next-20250516] +[If your patch is applied to the wrong git tree, kindly drop us a note. +And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Anna-Schumaker/NFS-Fixes-for-nfs4_proc_mkdir-error-handling/20250516-231124 base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next patch link: https://lore.kernel.org/r/20250516150010.61641-1-anna%40kernel.org patch subject: [PATCH] NFS: Fixes for nfs4_proc_mkdir() error handling +:::::: branch date: 2 days ago +:::::: commit date: 2 days ago config: i386-randconfig-141-20250517 (https://download.01.org/0day-ci/archive/20250518/202505181116.RhlCb75I-lkp@intel.com/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202505181116.RhlCb75I-lkp@intel.com/ New smatch warnings: fs/nfs/nfs4proc.c:5277 nfs4_proc_mkdir() warn: passing zero to 'PTR_ERR' +Old smatch warnings: +fs/nfs/nfs4proc.c:1471 nfs4_opendata_alloc() error: we previously assumed 'c' could be null (see line 1439) + vim +/PTR_ERR +5277 fs/nfs/nfs4proc.c +^1da177e4c3f41 Linus Torvalds 2005-04-16 5259 8376583b84a193 NeilBrown 2025-02-27 5260 static struct dentry *nfs4_proc_mkdir(struct inode *dir, struct dentry *dentry, ^1da177e4c3f41 Linus Torvalds 2005-04-16 5261 struct iattr *sattr) ^1da177e4c3f41 Linus Torvalds 2005-04-16 5262 { @@ -42,15 +61,6 @@ a8a5da996df7d2 Aneesh Kumar K.V 2010-12-09 5274 sattr->ia_mode &= ~curren 4c35d65f4c6f1e Anna Schumaker 2025-05-16 @5277 err = PTR_ERR(alias); 4c35d65f4c6f1e Anna Schumaker 2025-05-16 5278 if (err > 0) 4c35d65f4c6f1e Anna Schumaker 2025-05-16 5279 err = 0; - -This doesn't work. Imagine we are on a 64bit system and -_nfs4_proc_mkdir() returns a valid pointer. It depends on if BIT(31) -is set whether we return zero or a random negative number. - -This needs to be: - - err = PTR_ERR_OR_ZERO(alias); - 078ea3dfe396b1 Trond Myklebust 2013-08-12 5280 trace_nfs4_mkdir(dir, &dentry->d_name, err); 078ea3dfe396b1 Trond Myklebust 2013-08-12 5281 err = nfs4_handle_exception(NFS_SERVER(dir), err, ^1da177e4c3f41 Linus Torvalds 2005-04-16 5282 &exception); @@ -61,6 +71,7 @@ aa9c2669626ca7 David Quigley 2013-05-22 5285 4c35d65f4c6f1e Anna Schumaker 2025-05-16 5287 return ERR_PTR(err); 8376583b84a193 NeilBrown 2025-02-27 5288 return alias; ^1da177e4c3f41 Linus Torvalds 2005-04-16 5289 } +^1da177e4c3f41 Linus Torvalds 2005-04-16 5290 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index b9a4823..f1408d2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,40 +1,54 @@ - "ref\020250516150010.61641-1-anna@kernel.org\0" - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH] NFS: Fixes for nfs4_proc_mkdir() error handling\0" - "Date\0Fri, 23 May 2025 11:35:03 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - Anna Schumaker <anna@kernel.org> - linux-nfs@vger.kernel.org - " trond.myklebust@hammerspace.com\0" + "Date\0Sun, 18 May 2025 12:10:08 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - " anna@kernel.org\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "In-Reply-To: <20250516150010.61641-1-anna@kernel.org>\n" + "References: <20250516150010.61641-1-anna@kernel.org>\n" + "TO: Anna Schumaker <anna@kernel.org>\n" + "TO: linux-nfs@vger.kernel.org\n" + "TO: trond.myklebust@hammerspace.com\n" + "CC: anna@kernel.org\n" + "\n" "Hi Anna,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" + "[auto build test WARNING on trondmy-nfs/linux-next]\n" + "[also build test WARNING on linus/master v6.15-rc6 next-20250516]\n" + "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" + "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Anna-Schumaker/NFS-Fixes-for-nfs4_proc_mkdir-error-handling/20250516-231124\n" "base: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next\n" "patch link: https://lore.kernel.org/r/20250516150010.61641-1-anna%40kernel.org\n" "patch subject: [PATCH] NFS: Fixes for nfs4_proc_mkdir() error handling\n" + ":::::: branch date: 2 days ago\n" + ":::::: commit date: 2 days ago\n" "config: i386-randconfig-141-20250517 (https://download.01.org/0day-ci/archive/20250518/202505181116.RhlCb75I-lkp@intel.com/config)\n" "compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202505181116.RhlCb75I-lkp@intel.com/\n" "\n" "New smatch warnings:\n" "fs/nfs/nfs4proc.c:5277 nfs4_proc_mkdir() warn: passing zero to 'PTR_ERR'\n" "\n" + "Old smatch warnings:\n" + "fs/nfs/nfs4proc.c:1471 nfs4_opendata_alloc() error: we previously assumed 'c' could be null (see line 1439)\n" + "\n" "vim +/PTR_ERR +5277 fs/nfs/nfs4proc.c\n" "\n" + "^1da177e4c3f41 Linus Torvalds 2005-04-16 5259 \n" "8376583b84a193 NeilBrown 2025-02-27 5260 static struct dentry *nfs4_proc_mkdir(struct inode *dir, struct dentry *dentry,\n" "^1da177e4c3f41 Linus Torvalds 2005-04-16 5261 \t\t\t\t struct iattr *sattr)\n" "^1da177e4c3f41 Linus Torvalds 2005-04-16 5262 {\n" @@ -55,15 +69,6 @@ "4c35d65f4c6f1e Anna Schumaker 2025-05-16 @5277 \t\terr = PTR_ERR(alias);\n" "4c35d65f4c6f1e Anna Schumaker 2025-05-16 5278 \t\tif (err > 0)\n" "4c35d65f4c6f1e Anna Schumaker 2025-05-16 5279 \t\t\terr = 0;\n" - "\n" - "This doesn't work. Imagine we are on a 64bit system and\n" - "_nfs4_proc_mkdir() returns a valid pointer. It depends on if BIT(31)\n" - "is set whether we return zero or a random negative number.\n" - "\n" - "This needs to be:\n" - "\n" - "\terr = PTR_ERR_OR_ZERO(alias);\n" - "\n" "078ea3dfe396b1 Trond Myklebust 2013-08-12 5280 \t\ttrace_nfs4_mkdir(dir, &dentry->d_name, err);\n" "078ea3dfe396b1 Trond Myklebust 2013-08-12 5281 \t\terr = nfs4_handle_exception(NFS_SERVER(dir), err,\n" "^1da177e4c3f41 Linus Torvalds 2005-04-16 5282 \t\t\t\t&exception);\n" @@ -74,9 +79,10 @@ "4c35d65f4c6f1e Anna Schumaker 2025-05-16 5287 \t\treturn ERR_PTR(err);\n" "8376583b84a193 NeilBrown 2025-02-27 5288 \treturn alias;\n" "^1da177e4c3f41 Linus Torvalds 2005-04-16 5289 }\n" + "^1da177e4c3f41 Linus Torvalds 2005-04-16 5290 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -395862257ec85a26616fb5eac12adfbc5a2b2e8354d16c670f807989d9857d61 +71ea0375308031360faf105e29d4662101a5f93cf227b0222238e2704a9efe02
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.