All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: buildroot@buildroot.org, Chris Packham <judge.packham@gmail.com>,
	Thomas Devoogdt <thomas.devoogdt@barco.com>
Subject: Re: [Buildroot] [PATCH v1] package/syslog-ng: disable cloud auth if libressl is used
Date: Sun, 18 May 2025 15:04:36 +0200	[thread overview]
Message-ID: <20250518150436.3ab52127@windsurf> (raw)
In-Reply-To: <20250420070934.185346-1-thomas@devoogdt.com>

Hello Thomas,

On Sun, 20 Apr 2025 09:09:34 +0200
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> From: Thomas Devoogdt <thomas.devoogdt@barco.com>
> 
> ./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1158:33: error: invalid use of incomplete type 'struct ECDSA_SIG_st'
>      auto rr = helper::bn2raw(sig->r);
> 
> ./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1159:33: error: invalid use of incomplete type 'struct ECDSA_SIG_st'
>      auto rs = helper::bn2raw(sig->s);
> 
> ./modules/cloud-auth/jwt-cpp/include/jwt-cpp/jwt.h:1181:15: error: aggregate 'ECDSA_SIG sig' has incomplete type and cannot be defined
>      ECDSA_SIG sig;
> 
> Fixes:
> - https://autobuild.buildroot.org/results/d76/d76883e0870b4c788058fee1ac2c1c47a17f6bf2/build-end.log
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Thanks for the patch. However instead of this, can we fix the issue?
Looking at upstream jwt-cpp (which is bundled in syslog-ng cloud-auth
module), this snippet fixes it:

  https://github.com/Thalhammer/jwt-cpp/commit/c9a511f436eaa13857336ebeb44dbc5b7860fe01#diff-be2369ece29c0945fc04ffe13a39767b7841fc2fabd3df209a26b3bb381a2fb2

So could you make a syslog-ng patch that adjusts this, and report to
upstream syslog-ng the issue so that they update to a newer jwt-cpp
version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-05-18 13:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-20  7:09 [Buildroot] [PATCH v1] package/syslog-ng: disable cloud auth if libressl is used Thomas Devoogdt
2025-05-18 13:04 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250518150436.3ab52127@windsurf \
    --to=buildroot@buildroot.org \
    --cc=judge.packham@gmail.com \
    --cc=thomas.devoogdt@barco.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.