All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: virtio-comment@lists.linux.dev, Jason Wang <jasowang@redhat.com>,
	Willem de Bruijn <willemb@google.com>,
	Parav Pandit <parav@nvidia.com>,
	mvaralar@redhat.com, cohuck@redhat.com
Subject: Re: [PATCH] virtio-net: clarify guest offloads <> features mapping
Date: Mon, 19 May 2025 08:49:29 -0400	[thread overview]
Message-ID: <20250519084856-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <c6c9f59f-2960-4155-a984-a5f30586e7f6@redhat.com>

On Mon, May 19, 2025 at 12:21:57PM +0200, Paolo Abeni wrote:
> On 5/19/25 12:12 PM, Paolo Abeni wrote:
> > The guest offloads, as specified by 'Setting Offloads State,' use a
> > 64-bit wide space, while some of the corresponding virtio net features
> > are in the upper 64 bits of a 128-bit wide space.
> > 
> > Clarify the relevant mapping as somewhat implied by the current text.
> > Also rename the offload definitions to avoid referring to different
> > numeric values with the same name in the features table and in the
> > offload table.
> > 
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/225
> 
> I would like to ask a vote on this issues, thanks!
> 
> Paolo


Acked-by: Michael S. Tsirkin <mst@redhat.com>

Let's give people a couple of days to review pls.



  reply	other threads:[~2025-05-19 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-19 10:12 [PATCH] virtio-net: clarify guest offloads <> features mapping Paolo Abeni
2025-05-19 10:21 ` Paolo Abeni
2025-05-19 12:49   ` Michael S. Tsirkin [this message]
2025-05-19 15:12 ` Parav Pandit
2025-05-20  6:44   ` Paolo Abeni
2025-05-20  6:45     ` Parav Pandit
2025-05-20  0:50 ` Jason Wang
2025-05-20  6:39   ` Paolo Abeni
2025-05-21  1:05     ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250519084856-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mvaralar@redhat.com \
    --cc=pabeni@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.linux.dev \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.