From: Simon Horman <horms@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: airoha: Add FLOW_CLS_STATS callback support
Date: Mon, 19 May 2025 13:10:32 +0100 [thread overview]
Message-ID: <20250519121032.GF365796@horms.kernel.org> (raw)
In-Reply-To: <aCsAItPcz_9CuxaP@lore-desk>
On Mon, May 19, 2025 at 11:55:46AM +0200, Lorenzo Bianconi wrote:
> On May 19, Simon Horman wrote:
> > On Fri, May 16, 2025 at 10:00:00AM +0200, Lorenzo Bianconi wrote:
> >
> > ...
> >
> > > @@ -1027,6 +1255,15 @@ int airoha_ppe_init(struct airoha_eth *eth)
> > > if (!ppe->foe_flow)
> > > return -ENOMEM;
> > >
> > > + foe_size = PPE_STATS_NUM_ENTRIES * sizeof(*ppe->foe_stats);
> > > + if (foe_size) {
> >
> > Hi Lorenzo,
> >
> > It's unclear to me how foe_size can be zero.
>
> Hi Simon,
>
> foe_size will be 0 if you disable CONFIG_NET_AIROHA_FLOW_STATS since in this
> case PPE_STATS_NUM_ENTRIES will be 0.
Thanks,
I see that now but for some reason it escaped me earlier.
With that cleared up this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-05-19 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 7:59 [PATCH net-next v2 0/3] net: airoha: Add per-flow stats support to hw flowtable offloading Lorenzo Bianconi
2025-05-16 7:59 ` [PATCH net-next v2 1/3] net: airoha: npu: Move memory allocation in airoha_npu_send_msg() caller Lorenzo Bianconi
2025-05-19 12:13 ` Simon Horman
2025-05-16 8:00 ` [PATCH net-next v2 2/3] net: airoha: Add FLOW_CLS_STATS callback support Lorenzo Bianconi
2025-05-19 9:46 ` Simon Horman
2025-05-19 9:55 ` Lorenzo Bianconi
2025-05-19 12:10 ` Simon Horman [this message]
2025-05-16 8:00 ` [PATCH net-next v2 3/3] net: airoha: ppe: Disable packet keepalive Lorenzo Bianconi
2025-05-19 12:13 ` Simon Horman
2025-05-21 3:10 ` [PATCH net-next v2 0/3] net: airoha: Add per-flow stats support to hw flowtable offloading patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250519121032.GF365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.