diff for duplicates of <20250520122141.025616c9@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 0957c23..bf1f857 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,21 @@ -On Tue, 20 May 2025 10:59:34 +0800 Jinjian Song wrote: -> If it's not feasible to directly add parameters for configuring this RX buffer(BAT/FAG) to -> the mtk_t7xx driver, would it be allowed to add aparameter for a default configuration -> ratio (1/2, 1/4)? Or is it not recommended to use driver parameters for mtk_t7xx driver. +>On Tue, 20 May 2025 10:59:34 +0800 Jinjian Song wrote: +>> If it's not feasible to directly add parameters for configuring this RX buffer(BAT/FAG) to +>> the mtk_t7xx driver, would it be allowed to add aparameter for a default configuration +>> ratio (1/2, 1/4)? Or is it not recommended to use driver parameters for mtk_t7xx driver. +> +>Looks into devlink params then +> -Looks into devlink params then +Hi Jakub, + +The parameters are used by data plane to request RX DMA buffers for the entrire lifetime of +the driver, so it's best to determine them at the driver load time. Adjusting them after the +driver has been probed could introduce complex issues (e.g., the DMA buffers may already be +in use for communication when the parameters are changed. While devlink appears to support +parameter configuration via driver reload and runtime adjustment, both of these occur after +the driver has been probed, which doesn't seem very friendly to the overall logic. + +Thanks. + +Jinjian, +Best Regards. diff --git a/a/content_digest b/N1/content_digest index caa1d59..fdbda7f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,10 @@ "ref\020250514104728.10869-1-jinjian.song@fibocom.com\0" "ref\020250515180858.2568d930@kernel.org\0" "ref\020250516084320.66998caf@kernel.org\0" - "From\0Jakub Kicinski <kuba@kernel.org>\0" + "From\0Jinjian Song <jinjian.song@fibocom.com>\0" "Subject\0Re: [net-next v1] net: wwan: t7xx: Parameterize data plane RX BAT and FAG count\0" - "Date\0Tue, 20 May 2025 12:21:41 -0700\0" - "To\0Jinjian Song <jinjian.song@fibocom.com>\0" + "Date\0Wed, 4 Jun 2025 17:17:22 +0800\0" + "To\0kuba@kernel.org\0" "Cc\0andrew+netdev@lunn.ch" angelogioacchino.delregno@collabora.com chandrashekar.devegowda@intel.com @@ -16,6 +16,7 @@ haijun.liu@mediatek.com helgaas@kernel.org horms@kernel.org + jinjian.song@fibocom.com johannes@sipsolutions.net korneld@google.com linux-arm-kernel@lists.infradead.org @@ -32,11 +33,26 @@ " ryazanov.s.a@gmail.com\0" "\00:1\0" "b\0" - "On Tue, 20 May 2025 10:59:34 +0800 Jinjian Song wrote:\n" - "> If it's not feasible to directly add parameters for configuring this RX buffer(BAT/FAG) to \n" - "> the mtk_t7xx driver, would it be allowed to add aparameter for a default configuration \n" - "> ratio (1/2, 1/4)? Or is it not recommended to use driver parameters for mtk_t7xx driver.\n" + ">On Tue, 20 May 2025 10:59:34 +0800 Jinjian Song wrote:\n" + ">> If it's not feasible to directly add parameters for configuring this RX buffer(BAT/FAG) to \n" + ">> the mtk_t7xx driver, would it be allowed to add aparameter for a default configuration \n" + ">> ratio (1/2, 1/4)? Or is it not recommended to use driver parameters for mtk_t7xx driver.\n" + ">\n" + ">Looks into devlink params then\n" + ">\n" "\n" - Looks into devlink params then + "Hi Jakub,\n" + "\n" + "The parameters are used by data plane to request RX DMA buffers for the entrire lifetime of\n" + "the driver, so it's best to determine them at the driver load time. Adjusting them after the\n" + "driver has been probed could introduce complex issues (e.g., the DMA buffers may already be\n" + "in use for communication when the parameters are changed. While devlink appears to support\n" + "parameter configuration via driver reload and runtime adjustment, both of these occur after\n" + "the driver has been probed, which doesn't seem very friendly to the overall logic.\n" + "\n" + "Thanks.\n" + "\n" + "Jinjian,\n" + Best Regards. -03a3376f093b494f7379a4038616c2a274ae59f3f52b3d710b976caa66effa12 +0ce302ae181a87ef77313f8f0f3de9b3e2936b33b6ad7507f21b4526916a74a2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.