All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Jijie Shao <shaojijie@huawei.com>,
	"salil.mehta@huawei.com" <salil.mehta@huawei.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	" lanhao@huawei.com" <lanhao@huawei.com>,
	" wangpeiyang1@huawei.com" <wangpeiyang1@huawei.com>,
	" rosenp@gmail.com" <rosenp@gmail.com>,
	" liuyonglong@huawei.com" <liuyonglong@huawei.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: hns3: Add error handling for VLAN filter hardwareconfiguration
Date: Tue, 20 May 2025 15:37:36 +0100	[thread overview]
Message-ID: <20250520143736.GT365796@horms.kernel.org> (raw)
In-Reply-To: <682BD774.007007.29338@cstnet.cn>

On Tue, May 20, 2025 at 09:14:28AM +0800, Wentao Liang wrote:
> > Are there any real functional problems?
> > Would you please tell me your test cases? I'm going to try to reproduce the problem.
> 
> Hi,
> 
> I found this problem by static analysis and manual auditing. I believe there should be add a check just like the other call of hclge_set_vlan_filter_hw(). If the check is useless, could you please tell me the detailed reason.

Thanks,

I think it would be useful for the patch description to state
that the problem was found using static analysis.

But let's wait for more feedback from Jijie on if this
check is, at least theoretically, required.

  parent reply	other threads:[~2025-05-20 14:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-17 14:15 [PATCH] net: hns3: Add error handling for VLAN filter hardware configuration Wentao Liang
2025-05-19 15:30 ` Jijie Shao
     [not found]   ` <682BD774.007007.29338@cstnet.cn>
2025-05-20 14:37     ` Simon Horman [this message]
2025-05-21  2:43     ` [PATCH] net: hns3: Add error handling for VLAN filter hardwareconfiguration Jijie Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250520143736.GT365796@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=lanhao@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rosenp@gmail.com \
    --cc=salil.mehta@huawei.com \
    --cc=shaojijie@huawei.com \
    --cc=vulab@iscas.ac.cn \
    --cc=wangpeiyang1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.