From: Al Viro <viro@zeniv.linux.org.uk>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-unionfs@vger.kernel.org,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 4/6] fs: dcache locking for exlusion between overlayfs, casefolding
Date: Tue, 20 May 2025 16:25:36 +0100 [thread overview]
Message-ID: <20250520152536.GD2023217@ZenIV> (raw)
In-Reply-To: <20250520051600.1903319-5-kent.overstreet@linux.dev>
On Tue, May 20, 2025 at 01:15:56AM -0400, Kent Overstreet wrote:
> +int d_casefold_enable(struct dentry *dentry, struct d_casefold_enable *e)
> +{
> + struct dentry *root = dentry->d_sb->s_root;
> + int ret = 0;
> +
> + guard(mutex)(&no_casefold_dentries_lock);
> +
> + for (struct dentry *i = dentry;
> + i && i->d_inode->i_flags & S_NO_CASEFOLD;
> + i = i != root ? i->d_parent : NULL) {
> + ret = darray_push(&e->refs, i);
> + if (ret)
> + goto err;
> +
> + ret = no_casefold_dentry_get(i, ref_casefold_enable);
Beyond being fucking ugly, this is outright broken. Lose
the timeslice (e.g. on allocation in that thing), and there's
nothing to prevent your 'i' from pointing to freed memory.
next prev parent reply other threads:[~2025-05-20 15:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 5:15 [PATCH 0/6] overlayfs + casefolding Kent Overstreet
2025-05-20 5:15 ` [PATCH 1/6] bcachefs: BCH_INODE_has_case_insensitive Kent Overstreet
2025-05-20 5:15 ` [PATCH 2/6] darray: lift from bcachefs Kent Overstreet
2025-05-20 5:15 ` [PATCH 3/6] fs: SB_CASEFOLD Kent Overstreet
2025-05-20 5:15 ` [PATCH 4/6] fs: dcache locking for exlusion between overlayfs, casefolding Kent Overstreet
2025-05-20 15:25 ` Al Viro [this message]
2025-05-20 15:27 ` Kent Overstreet
2025-05-23 11:54 ` [PATCH v2] fs: dcache " Kent Overstreet
2025-05-20 5:15 ` [PATCH 5/6] bcachefs: Hook up d_casefold_enable() Kent Overstreet
2025-05-20 5:15 ` [PATCH 6/6] overlayfs: Support casefolded filesystems Kent Overstreet
2025-05-20 8:05 ` [PATCH 0/6] overlayfs + casefolding Amir Goldstein
2025-05-20 12:25 ` Kent Overstreet
2025-05-20 12:40 ` Amir Goldstein
2025-05-20 12:43 ` Kent Overstreet
2025-05-20 14:03 ` Amir Goldstein
2025-05-20 14:12 ` Kent Overstreet
2025-05-20 14:33 ` Amir Goldstein
2025-05-20 14:44 ` Kent Overstreet
2025-05-20 15:13 ` Amir Goldstein
2025-05-20 15:21 ` Kent Overstreet
2025-05-20 16:40 ` Miklos Szeredi
2025-05-20 16:49 ` Kent Overstreet
2025-05-23 14:10 ` Kent Overstreet
2025-05-23 17:14 ` Amir Goldstein
2025-05-23 20:30 ` Amir Goldstein
2025-05-23 21:09 ` Kent Overstreet
2025-05-24 13:01 ` Amir Goldstein
2025-05-25 18:27 ` Kent Overstreet
2025-05-27 8:57 ` Amir Goldstein
2025-05-27 18:07 ` Kent Overstreet
2025-05-20 18:49 ` John Stoffel
2025-05-21 1:49 ` Kent Overstreet
2025-05-22 21:44 ` John Stoffel
2025-05-21 11:26 ` Malte Schröder
2025-05-22 7:53 ` Christopher Snowhill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520152536.GD2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.