From: Simon Horman <horms@kernel.org>
To: jiang.kun2@zte.com.cn
Cc: kuniyu@amazon.com, davem@davemloft.net, edumazet@google.com,
fan.yu9@zte.com.cn, gnaaman@drivenets.com, he.peilin@zte.com.cn,
kuba@kernel.org, leitao@debian.org, linux-kernel@vger.kernel.org,
lizetao1@huawei.com, netdev@vger.kernel.org, pabeni@redhat.com,
qiu.yutan@zte.com.cn, tu.qiang35@zte.com.cn,
wang.yaxin@zte.com.cn, xu.xin16@zte.com.cn,
yang.yang29@zte.com.cn, ye.xingchen@zte.com.cn,
zhang.yunkai@zte.com.cn
Subject: Re: [PATCH linux next] net: neigh: use kfree_skb_reason() in neigh_resolve_output()
Date: Tue, 20 May 2025 19:05:52 +0100 [thread overview]
Message-ID: <20250520180552.GP365796@horms.kernel.org> (raw)
In-Reply-To: <20250520184032009VEzfxkkFmbQjfs0qCJ5QB@zte.com.cn>
On Tue, May 20, 2025 at 06:40:32PM +0800, jiang.kun2@zte.com.cn wrote:
> >Is there any reason you don't change neigh_connected_output() ?
> >
> >
> >If you respin, please specify net-next and the patch version in
> >
> >Subject: [PATCH v2 net-next] net: neighbour: ...
> >
>
> Thank you for your feedback.
> I notice that most commits related to kfree_skb_reason() involve changes
> within the scope of a single function, which aligns with the meaning of
> the commit titles. I consider this approach appropriate as it facilitates
> both modification and traceability. Following this approach, I will submit
> another new patch to specifically modify neigh_connected_output().
I think it makes sense to make changes that are closely related,
as seems to be the case here, in a single patch.
--
pw-bot: changes-requested
prev parent reply other threads:[~2025-05-20 18:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 2:44 [PATCH linux next] net: neigh: use kfree_skb_reason() in neigh_resolve_output() jiang.kun2
2025-05-20 4:58 ` Kuniyuki Iwashima
2025-05-20 10:40 ` jiang.kun2
2025-05-20 18:05 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520180552.GP365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fan.yu9@zte.com.cn \
--cc=gnaaman@drivenets.com \
--cc=he.peilin@zte.com.cn \
--cc=jiang.kun2@zte.com.cn \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qiu.yutan@zte.com.cn \
--cc=tu.qiang35@zte.com.cn \
--cc=wang.yaxin@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.