From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch,
pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com,
Stanislav Fomichev <sdf@fomichev.me>
Subject: Re: [PATCH net 1/3] bnxt_en: Fix netdev locking in ULP IRQ functions
Date: Tue, 20 May 2025 19:10:24 -0700 [thread overview]
Message-ID: <20250520191024.1b92e207@kernel.org> (raw)
In-Reply-To: <20250519204130.3097027-2-michael.chan@broadcom.com>
On Mon, 19 May 2025 13:41:28 -0700 Michael Chan wrote:
> netdev_lock is already held when calling bnxt_ulp_irq_stop() and
> bnxt_ulp_irq_restart(). When converting rtnl_lock to netdev_lock,
> the original code was rtnl_dereference() to indicate that rtnl_lock
> was already held. rcu_dereference_protected() is the correct
> conversion after replacing rtnl_lock with netdev_lock.
>
> Add a new helper netdev_lock_dereference() similar to
> rtnl_dereference().
I'll apply this one as is since its for the current release
next prev parent reply other threads:[~2025-05-21 2:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 20:41 [PATCH net 0/3] bnxt_en: 2 bug fixes Michael Chan
2025-05-19 20:41 ` [PATCH net 1/3] bnxt_en: Fix netdev locking in ULP IRQ functions Michael Chan
2025-05-20 14:41 ` Simon Horman
2025-05-21 2:10 ` Jakub Kicinski [this message]
2025-05-19 20:41 ` [PATCH net 2/3] bnxt_en: Add a helper function to configure MRU and RSS Michael Chan
2025-05-20 14:41 ` Simon Horman
2025-05-20 14:57 ` David Wei
2025-05-19 20:41 ` [PATCH net 3/3] bnxt_en: Update MRU and RSS table of RSS contexts on queue reset Michael Chan
2025-05-20 14:42 ` Simon Horman
2025-05-20 14:59 ` David Wei
2025-05-21 1:28 ` Jakub Kicinski
2025-05-21 1:38 ` Michael Chan
2025-05-21 1:51 ` Jakub Kicinski
2025-05-21 2:10 ` Michael Chan
2025-05-21 2:17 ` Jakub Kicinski
2025-05-21 2:29 ` Michael Chan
2025-05-22 11:01 ` David Wei
2025-05-22 15:26 ` Jakub Kicinski
2025-05-27 15:37 ` David Wei
2025-05-27 16:50 ` Michael Chan
2025-05-21 2:20 ` [PATCH net 0/3] bnxt_en: 2 bug fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520191024.1b92e207@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.