From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>
Subject: Re: [PATCH 2/3] blk-zoned: Move locking into disk_zone_wplug_abort()
Date: Wed, 21 May 2025 08:00:26 +0200 [thread overview]
Message-ID: <20250521060026.GC3109@lst.de> (raw)
In-Reply-To: <20250521000626.1314859-3-bvanassche@acm.org>
On Tue, May 20, 2025 at 05:06:25PM -0700, Bart Van Assche wrote:
> Instead of holding zwplug->lock around disk_zone_wplug_abort() calls, make
> disk_zone_wplug_abort() obtain zwplug->lock. Prepare for reducing the amount
> of code protected by zwplug->lock. No functionality has been changed.
Besides the comments from the last patch that apply here as well,
this does change critical sections withoyut any explanation of why
that is desirable and an explanation of why it is safe.
next prev parent reply other threads:[~2025-05-21 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 0:06 [PATCH 0/3] Hold the zoned write plug lock less long Bart Van Assche
2025-05-21 0:06 ` [PATCH 1/3] blk-zoned: Move locking into disk_zone_wplug_set_wp_offset() Bart Van Assche
2025-05-21 5:58 ` Christoph Hellwig
2025-05-21 0:06 ` [PATCH 2/3] blk-zoned: Move locking into disk_zone_wplug_abort() Bart Van Assche
2025-05-21 6:00 ` Christoph Hellwig [this message]
2025-05-21 0:06 ` [PATCH 3/3] blk-zoned: Do not lock zwplug->lock recursively Bart Van Assche
2025-05-21 6:02 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521060026.GC3109@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.