From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Nilay Shroff <nilay@linux.ibm.com>,
linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
sth@linux.ibm.com, gjoyce@ibm.com
Subject: Re: [PATCH] block: fix lock dependency between percpu alloc lock and elevator lock
Date: Wed, 21 May 2025 08:03:57 +0200 [thread overview]
Message-ID: <20250521060357.GA3404@lst.de> (raw)
In-Reply-To: <aC1Ropdb5x05WCIc@fedora>
On Wed, May 21, 2025 at 12:08:02PM +0800, Ming Lei wrote:
> Not dig into this implementation, will look into later.
>
> I guess it should work by extending elv_change_ctx.
>
> However we have other elevator_queue lifetime issue, that is why
> ->elevator_lock is used almost everywhere.
>
> Another solution is to move all `sched_data` into 'struct elevator_queue':
With "sched_data" you primarily mean the sched tags here, right?
Anyway, getting scheduler owned items out of the request_queue and into
the elevator data seems like the right thing to do, but it might indeed
be very invasive.
next prev parent reply other threads:[~2025-05-21 6:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 10:33 [PATCH] block: fix lock dependency between percpu alloc lock and elevator lock Nilay Shroff
2025-05-21 4:08 ` Ming Lei
2025-05-21 6:03 ` Christoph Hellwig [this message]
2025-05-21 7:40 ` Nilay Shroff
-- strict thread matches above, loose matches on Subject: below --
2025-05-21 3:34 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521060357.GA3404@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gjoyce@ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=sth@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.