From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6DE0C54E71 for ; Wed, 21 May 2025 06:09:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7B2310E622; Wed, 21 May 2025 06:09:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="cayQCvX9"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A79410E625 for ; Wed, 21 May 2025 06:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1747807757; bh=L4OQtarvf/1bJvzk2XlyPF3hgExBeKzDuxc92ewezoQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cayQCvX9UdhV30m49XW8d7V4VpiLD07dq+iHWSLqUJQxxejtSuQxpKpqlAAlKsjBT L5/LPl9UmpsSLMSVI+izwuqFdHCqJELKumry4Tnm+h0Zgm6icXJ1vE4TfFRe81/VwV bTGwTrzNv+RcPkBZW22iShrRBnqK91qBCvky3HzETzi+ec2KAE2JDqn5IJnlDKCk7u RAXDLs7acDPzOmxp/xPoWhNrrHom3AXM5Vkw/awvjZbqy4TDWEocX8J4LvK+uOXmzd 4yDAgjhKS5pkonaz/jHmlNfRWY8mIwOLT8UcKT8aXnKtPUQ4iSOhg/lbjykD2xSGxi g0hvxnO0/scbA== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id B383917E0FBA; Wed, 21 May 2025 08:09:16 +0200 (CEST) Date: Wed, 21 May 2025 08:09:13 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com, Steven Price , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH v3 1/5] drm/panfrost: Add BO labelling to Panfrost Message-ID: <20250521080913.476d8b78@collabora.com> In-Reply-To: <20250520174634.353267-2-adrian.larumbe@collabora.com> References: <20250520174634.353267-1-adrian.larumbe@collabora.com> <20250520174634.353267-2-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 20 May 2025 18:43:58 +0100 Adri=C3=A1n Larumbe wrote: > Functions for labelling UM-exposed an internal BOs are provided. An > example of the latter would be the Perfcnt sample buffer. >=20 > This commit is done in preparation of a following one that will allow > UM to set BO labels through a new ioctl(). >=20 > Signed-off-by: Adri=C3=A1n Larumbe > Reviewed-by: Steven Price Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_gem.c | 42 +++++++++++++++++++++++++ > drivers/gpu/drm/panfrost/panfrost_gem.h | 17 ++++++++++ > 2 files changed, 59 insertions(+) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/pa= nfrost/panfrost_gem.c > index 963f04ba2de6..4c5be7ccc9cc 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gem.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* Copyright 2019 Linaro, Ltd, Rob Herring */ > =20 > +#include > #include > #include > #include > @@ -35,6 +36,9 @@ static void panfrost_gem_free_object(struct drm_gem_obj= ect *obj) > */ > WARN_ON_ONCE(!list_empty(&bo->mappings.list)); > =20 > + kfree_const(bo->label.str); > + mutex_destroy(&bo->label.lock); > + > if (bo->sgts) { > int i; > int n_sgt =3D bo->base.base.size / SZ_2M; > @@ -260,6 +264,7 @@ struct drm_gem_object *panfrost_gem_create_object(str= uct drm_device *dev, size_t > mutex_init(&obj->mappings.lock); > obj->base.base.funcs =3D &panfrost_gem_funcs; > obj->base.map_wc =3D !pfdev->coherent; > + mutex_init(&obj->label.lock); > =20 > return &obj->base.base; > } > @@ -302,3 +307,40 @@ panfrost_gem_prime_import_sg_table(struct drm_device= *dev, > =20 > return obj; > } > + > +void > +panfrost_gem_set_label(struct drm_gem_object *obj, const char *label) > +{ > + struct panfrost_gem_object *bo =3D to_panfrost_bo(obj); > + const char *old_label; > + > + scoped_guard(mutex, &bo->label.lock) { > + old_label =3D bo->label.str; > + bo->label.str =3D label; > + } > + > + kfree_const(old_label); > +} > + > +void > +panfrost_gem_internal_set_label(struct drm_gem_object *obj, const char *= label) > +{ > + struct panfrost_gem_object *bo =3D to_panfrost_bo(obj); > + const char *str; > + > + /* We should never attempt labelling a UM-exposed GEM object */ > + if (drm_WARN_ON(bo->base.base.dev, bo->base.base.handle_count > 0)) > + return; > + > + if (!label) > + return; > + > + str =3D kstrdup_const(label, GFP_KERNEL); > + if (!str) { > + /* Failing to allocate memory for a label isn't a fatal condition */ > + drm_warn(bo->base.base.dev, "Not enough memory to allocate BO label"); > + return; > + } > + > + panfrost_gem_set_label(obj, str); > +} > diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.h b/drivers/gpu/drm/pa= nfrost/panfrost_gem.h > index 7516b7ecf7fe..6c187b9b66fc 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gem.h > +++ b/drivers/gpu/drm/panfrost/panfrost_gem.h > @@ -41,6 +41,20 @@ struct panfrost_gem_object { > */ > size_t heap_rss_size; > =20 > + /** > + * @label: BO tagging fields. The label can be assigned within the > + * driver itself or through a specific IOCTL. > + */ > + struct { > + /** > + * @label.str: Pointer to NULL-terminated string, > + */ > + const char *str; > + > + /** @lock.str: Protects access to the @label.str field. */ > + struct mutex lock; > + } label; > + > bool noexec :1; > bool is_heap :1; > }; > @@ -89,4 +103,7 @@ void panfrost_gem_teardown_mappings_locked(struct panf= rost_gem_object *bo); > int panfrost_gem_shrinker_init(struct drm_device *dev); > void panfrost_gem_shrinker_cleanup(struct drm_device *dev); > =20 > +void panfrost_gem_set_label(struct drm_gem_object *obj, const char *labe= l); > +void panfrost_gem_internal_set_label(struct drm_gem_object *obj, const c= har *label); > + > #endif /* __PANFROST_GEM_H__ */ >=20 > base-commit: 9ff4fdf4f44b69237c0afc1d3a8dac916ce66f3e