From: Jakub Kicinski <kuba@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Hillf Danton <hdanton@sina.com>,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH (EXPERIMENTAL)] team: replace term lock with rtnl lock
Date: Wed, 21 May 2025 10:59:00 -0700 [thread overview]
Message-ID: <20250521105900.3111b6c1@kernel.org> (raw)
In-Reply-To: <9a12cdc9-1332-4ae5-8639-c71c91336b99@I-love.SAKURA.ne.jp>
On Wed, 21 May 2025 22:54:51 +0900 Tetsuo Handa wrote:
> On 2025/05/18 0:09, Jakub Kicinski wrote:
> > I think this was a trylock because there are places we try to cancel
> > this work while already holding the lock.
>
> I checked rtnl_unlock(), and it seems to me that rtnl_unlock() calls mutex_unlock() before
> doing operations that might sleep. Then, rtnl_unlock() itself won't increase possibility of
> rtnl_trylock() failure...
I don't think you understood my comment :(
next prev parent reply other threads:[~2025-05-21 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-17 7:32 [PATCH (EXPERIMENTAL)] team: replace term lock with rtnl lock Tetsuo Handa
2025-05-17 15:09 ` Jakub Kicinski
2025-05-21 13:54 ` Tetsuo Handa
2025-05-21 17:59 ` Jakub Kicinski [this message]
2025-05-20 9:23 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250521105900.3111b6c1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hdanton@sina.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.