All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: dri-devel@lists.freedesktop.org, tzimmermann@suse.de
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 3/9] firmware/tegra: avoid accessing iosys_map internals.
Date: Thu, 22 May 2025 16:52:12 +1000	[thread overview]
Message-ID: <20250522065519.318013-4-airlied@gmail.com> (raw)
In-Reply-To: <20250522065519.318013-1-airlied@gmail.com>

From: Dave Airlie <airlied@redhat.com>

Use the new accessor interfaces to avoid directly accessing the
internals.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/firmware/tegra/ivc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/firmware/tegra/ivc.c b/drivers/firmware/tegra/ivc.c
index 8c9aff9804c0..eb59acb08065 100644
--- a/drivers/firmware/tegra/ivc.c
+++ b/drivers/firmware/tegra/ivc.c
@@ -629,18 +629,18 @@ static inline void iosys_map_copy(struct iosys_map *dst, const struct iosys_map
 
 static inline unsigned long iosys_map_get_address(const struct iosys_map *map)
 {
-	if (map->is_iomem)
-		return (unsigned long)map->vaddr_iomem;
+	if (iosys_map_is_iomem(map)
+		return (unsigned long)iosys_map_ioptr(map);
 
-	return (unsigned long)map->vaddr;
+	return (unsigned long)iosys_map_ptr(map);
 }
 
 static inline void *iosys_map_get_vaddr(const struct iosys_map *map)
 {
-	if (WARN_ON(map->is_iomem))
+	if (WARN_ON(iosys_map_is_iomem(map)))
 		return NULL;
 
-	return map->vaddr;
+	return iosys_map_ptr(map);
 }
 
 int tegra_ivc_init(struct tegra_ivc *ivc, struct device *peer, const struct iosys_map *rx,
-- 
2.49.0


  parent reply	other threads:[~2025-05-22  6:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-22  6:52 iosys-map: refactor to reduce struct size Dave Airlie
2025-05-22  6:52 ` [PATCH 1/9] iosys-map: add new accessor interfaces and use them internally Dave Airlie
2025-05-22 11:58   ` Thomas Zimmermann
2025-05-22 13:34     ` Lucas De Marchi
2025-05-22 14:00       ` Thomas Zimmermann
2025-05-22  6:52 ` [PATCH 2/9] udmabuf: use new iosys_map accessors Dave Airlie
2025-05-22  6:52 ` Dave Airlie [this message]
2025-05-23  0:32   ` [PATCH 3/9] firmware/tegra: avoid accessing iosys_map internals kernel test robot
2025-05-22  6:52 ` [PATCH 4/9] drm/xe: avoid accessing internals of iosys_map Dave Airlie
2025-05-22 13:56   ` Lucas De Marchi
2025-05-22  6:52 ` [PATCH 5/9] drm/qxl: avoid accessing iosys_map internals Dave Airlie
2025-05-22 13:39   ` Lucas De Marchi
2025-05-22  6:52 ` [PATCH 6/9] drm/ttm: " Dave Airlie
2025-05-22  6:52 ` [PATCH 7/9] drm: " Dave Airlie
2025-05-22  6:52 ` [PATCH 8/9] iosys: hide internal details of implementation Dave Airlie
2025-05-22 12:05   ` Thomas Zimmermann
2025-05-22 23:30   ` kernel test robot
2025-05-22  6:52 ` [PATCH 9/9] iosys_map: embed the is_iomem bit into the pointer Dave Airlie
2025-05-22  8:48   ` Jani Nikula
2025-05-22 12:10   ` Thomas Zimmermann
2025-05-22 15:09   ` Lucas De Marchi
2025-05-22 20:32     ` Dave Airlie
2025-05-22 21:05       ` Lucas De Marchi
2025-05-23 12:31         ` Jocelyn Falempe
2025-05-26  6:39     ` Thomas Zimmermann
2025-05-26  7:58       ` Dave Airlie
2025-05-26  8:14         ` Thomas Zimmermann
2025-05-22  7:13 ` iosys-map: refactor to reduce struct size Dave Airlie
2025-05-22  7:20 ` ✓ CI.Patch_applied: success for series starting with [1/9] iosys-map: add new accessor interfaces and use them internally Patchwork
2025-05-22  7:20 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-22  7:21 ` ✗ CI.KUnit: failure " Patchwork
2025-05-22 12:00 ` iosys-map: refactor to reduce struct size Thomas Zimmermann
2025-05-22 13:59 ` Lucas De Marchi
2025-06-27 17:31 ` Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250522065519.318013-4-airlied@gmail.com \
    --to=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.