From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Richard Cochran" <richardcochran@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
Moshe Shemesh <moshe@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Gal Pressman <gal@nvidia.com>, Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next 4/5] net/mlx5e: Don't drop RTNL during firmware flash
Date: Thu, 22 May 2025 09:00:15 -0700 [thread overview]
Message-ID: <20250522090015.60147b61@kernel.org> (raw)
In-Reply-To: <1747829342-1018757-5-git-send-email-tariqt@nvidia.com>
On Wed, 21 May 2025 15:09:01 +0300 Tariq Toukan wrote:
> However, the stack is moving towards netdev instance locking and
> dropping and reacquiring RTNL in the context of flashing introduces
> locking ordering issues: RTNL must be acquired before the netdev
> instance lock and released after it.
>
> This patch therefore takes the simpler approach by no longer dropping
> and reacquiring the RTNL, as soon RTNL for ethtool will be removed,
> leaving only the instance lock to protect against races.
You didn't mention it so just in case someone tries to report this
as a regression later - devlink has been the preferred way to flash
devices for 5+ years. It has much better UX with the progress
notifications, and already does per-instance locking.
next prev parent reply other threads:[~2025-05-22 16:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 12:08 [PATCH net-next 0/5] net/mlx5: Convert mlx5 to netdev instance locking Tariq Toukan
2025-05-21 12:08 ` [PATCH net-next 1/5] IB/IPoIB: Enqueue separate work_structs for each flushed interface Tariq Toukan
2025-05-21 12:08 ` [PATCH net-next 2/5] IB/IPoIB: Replace vlan_rwsem with the netdev instance lock Tariq Toukan
2025-05-21 12:09 ` [PATCH net-next 3/5] IB/IPoIB: Allow using netdevs that require the " Tariq Toukan
2025-05-21 12:09 ` [PATCH net-next 4/5] net/mlx5e: Don't drop RTNL during firmware flash Tariq Toukan
2025-05-22 16:00 ` Jakub Kicinski [this message]
2025-05-21 12:09 ` [PATCH net-next 5/5] net/mlx5e: Convert mlx5 netdevs to instance locking Tariq Toukan
2025-05-21 18:27 ` Stanislav Fomichev
2025-05-21 20:37 ` Cosmin Ratiu
2025-05-22 15:28 ` Stanislav Fomichev
2025-05-22 15:51 ` [PATCH net-next 0/5] net/mlx5: Convert mlx5 to netdev " Jakub Kicinski
2025-05-22 16:10 ` Leon Romanovsky
2025-05-22 16:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522090015.60147b61@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cratiu@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hawk@kernel.org \
--cc=jgg@ziepe.ca \
--cc=john.fastabend@gmail.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.