diff for duplicates of <202505221209.UJOI2rXT-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 77e0921..416a4ae 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,20 +1,13 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -TO: Benjamin Marzinski <bmarzins@redhat.com> -CC: Mikulas Patocka <mpatocka@redhat.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 7bac2c97af4078d7a627500c9bcdd5b033f97718 commit: 5c977f1023156938915c57d362fddde8fad2b052 [10969/12618] dm-mpath: Don't grab work_mutex while probing paths -:::::: branch date: 17 hours ago -:::::: commit date: 6 days ago config: i386-randconfig-141-20250521 (https://download.01.org/0day-ci/archive/20250522/202505221209.UJOI2rXT-lkp@intel.com/config) compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <error27@gmail.com> +| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> | Closes: https://lore.kernel.org/r/202505221209.UJOI2rXT-lkp@intel.com/ smatch warnings: @@ -22,19 +15,6 @@ drivers/md/dm-mpath.c:2104 probe_active_paths() warn: mixing irqsave and irq vim +2104 drivers/md/dm-mpath.c -7734fb4ad98c3f Kevin Wolf 2025-04-29 2082 -7734fb4ad98c3f Kevin Wolf 2025-04-29 2083 /* -7734fb4ad98c3f Kevin Wolf 2025-04-29 2084 * Probe all active paths in current_pg to find out whether they still work. -7734fb4ad98c3f Kevin Wolf 2025-04-29 2085 * Fail all paths that do not work. -7734fb4ad98c3f Kevin Wolf 2025-04-29 2086 * -7734fb4ad98c3f Kevin Wolf 2025-04-29 2087 * Return -ENOTCONN if no valid path is left (even outside of current_pg). We -7734fb4ad98c3f Kevin Wolf 2025-04-29 2088 * cannot probe paths in other pgs without switching current_pg, so if valid -7734fb4ad98c3f Kevin Wolf 2025-04-29 2089 * paths are only in different pgs, they may or may not work. Additionally -7734fb4ad98c3f Kevin Wolf 2025-04-29 2090 * we should not probe paths in a pathgroup that is in the process of -7734fb4ad98c3f Kevin Wolf 2025-04-29 2091 * Initializing. Userspace can submit a request and we'll switch and wait -7734fb4ad98c3f Kevin Wolf 2025-04-29 2092 * for the pathgroup to be initialized. If the request fails, it may need to -7734fb4ad98c3f Kevin Wolf 2025-04-29 2093 * probe again. -7734fb4ad98c3f Kevin Wolf 2025-04-29 2094 */ 7734fb4ad98c3f Kevin Wolf 2025-04-29 2095 static int probe_active_paths(struct multipath *m) 7734fb4ad98c3f Kevin Wolf 2025-04-29 2096 { 7734fb4ad98c3f Kevin Wolf 2025-04-29 2097 struct pgpath *pgpath; @@ -43,10 +23,19 @@ vim +2104 drivers/md/dm-mpath.c 7734fb4ad98c3f Kevin Wolf 2025-04-29 2100 int r = 0; 7734fb4ad98c3f Kevin Wolf 2025-04-29 2101 7734fb4ad98c3f Kevin Wolf 2025-04-29 2102 spin_lock_irqsave(&m->lock, flags); + +_irqsave() is for if we don't know if the caller has disabled IRQs or +not. + 5c977f10231569 Benjamin Marzinski 2025-05-15 2103 if (test_bit(MPATHF_DELAY_PG_SWITCH, &m->flags)) { 5c977f10231569 Benjamin Marzinski 2025-05-15 @2104 wait_event_lock_irq(m->probe_wait, 5c977f10231569 Benjamin Marzinski 2025-05-15 2105 !test_bit(MPATHF_DELAY_PG_SWITCH, &m->flags), 5c977f10231569 Benjamin Marzinski 2025-05-15 2106 m->lock); + +The wait_event_lock_irq() macro calls spin_unlock_irq(), so hopefully +none of the callers of probe_active_paths() actually relied on having +IRQs disabled. + 5c977f10231569 Benjamin Marzinski 2025-05-15 2107 /* 5c977f10231569 Benjamin Marzinski 2025-05-15 2108 * if we waited because a probe was already in progress, 5c977f10231569 Benjamin Marzinski 2025-05-15 2109 * and it probed the current active pathgroup, don't @@ -89,7 +78,6 @@ vim +2104 drivers/md/dm-mpath.c 5c977f10231569 Benjamin Marzinski 2025-05-15 2146 wake_up(&m->probe_wait); 7734fb4ad98c3f Kevin Wolf 2025-04-29 2147 return r; 7734fb4ad98c3f Kevin Wolf 2025-04-29 2148 } -7734fb4ad98c3f Kevin Wolf 2025-04-29 2149 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 5284995..f30665b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,28 +1,23 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" "Subject\0[linux-next:master 10969/12618] drivers/md/dm-mpath.c:2104 probe_active_paths() warn: mixing irqsave and irq\0" - "Date\0Thu, 22 May 2025 12:37:34 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Fri, 23 May 2025 12:43:22 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Benjamin Marzinski <bmarzins@redhat.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + " Mikulas Patocka <mpatocka@redhat.com>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "TO: Benjamin Marzinski <bmarzins@redhat.com>\n" - "CC: Mikulas Patocka <mpatocka@redhat.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master\n" "head: 7bac2c97af4078d7a627500c9bcdd5b033f97718\n" "commit: 5c977f1023156938915c57d362fddde8fad2b052 [10969/12618] dm-mpath: Don't grab work_mutex while probing paths\n" - ":::::: branch date: 17 hours ago\n" - ":::::: commit date: 6 days ago\n" "config: i386-randconfig-141-20250521 (https://download.01.org/0day-ci/archive/20250522/202505221209.UJOI2rXT-lkp@intel.com/config)\n" "compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <error27@gmail.com>\n" + "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" "| Closes: https://lore.kernel.org/r/202505221209.UJOI2rXT-lkp@intel.com/\n" "\n" "smatch warnings:\n" @@ -30,19 +25,6 @@ "\n" "vim +2104 drivers/md/dm-mpath.c\n" "\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2082 \n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2083 /*\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2084 * Probe all active paths in current_pg to find out whether they still work.\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2085 * Fail all paths that do not work.\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2086 *\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2087 * Return -ENOTCONN if no valid path is left (even outside of current_pg). We\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2088 * cannot probe paths in other pgs without switching current_pg, so if valid\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2089 * paths are only in different pgs, they may or may not work. Additionally\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2090 * we should not probe paths in a pathgroup that is in the process of\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2091 * Initializing. Userspace can submit a request and we'll switch and wait\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2092 * for the pathgroup to be initialized. If the request fails, it may need to\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2093 * probe again.\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2094 */\n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2095 static int probe_active_paths(struct multipath *m)\n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2096 {\n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2097 \tstruct pgpath *pgpath;\n" @@ -51,10 +33,19 @@ "7734fb4ad98c3f Kevin Wolf 2025-04-29 2100 \tint r = 0;\n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2101 \n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2102 \tspin_lock_irqsave(&m->lock, flags);\n" + "\n" + "_irqsave() is for if we don't know if the caller has disabled IRQs or\n" + "not.\n" + "\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 2103 \tif (test_bit(MPATHF_DELAY_PG_SWITCH, &m->flags)) {\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 @2104 \t\twait_event_lock_irq(m->probe_wait,\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 2105 \t\t\t\t !test_bit(MPATHF_DELAY_PG_SWITCH, &m->flags),\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 2106 \t\t\t\t m->lock);\n" + "\n" + "The wait_event_lock_irq() macro calls spin_unlock_irq(), so hopefully\n" + "none of the callers of probe_active_paths() actually relied on having\n" + "IRQs disabled.\n" + "\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 2107 \t\t/*\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 2108 \t\t * if we waited because a probe was already in progress,\n" "5c977f10231569 Benjamin Marzinski 2025-05-15 2109 \t\t * and it probed the current active pathgroup, don't\n" @@ -97,10 +88,9 @@ "5c977f10231569 Benjamin Marzinski 2025-05-15 2146 \t\twake_up(&m->probe_wait);\n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2147 \treturn r;\n" "7734fb4ad98c3f Kevin Wolf 2025-04-29 2148 }\n" - "7734fb4ad98c3f Kevin Wolf 2025-04-29 2149 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -0c01aa9ab6a3ee6367f64332a6e186ff5eaa8f4c847fe3c2110e918043c4feec +bfb3f8e517254dccb3b75556c98e755ef5f70ad3389efe9346c58cd3159b622f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.