From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Cosmin Tanislav <demonsingur@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Romain Gantois <romain.gantois@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new()
Date: Thu, 22 May 2025 12:10:56 +0200 [thread overview]
Message-ID: <20250522121056.685637cd@booty> (raw)
In-Reply-To: <aC7lUE4kj8fnVVgM@shikoro>
On Thu, 22 May 2025 10:50:24 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> On Wed, May 07, 2025 at 03:19:13PM +0300, Cosmin Tanislav wrote:
> > In preparation for adding multiple flags that change the behavior,
> > add a flags parameter to i2c_atr_new() and an i2c_atr_flags enum.
> >
> > Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> > Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> > Reviewed-by: Romain Gantois <romain.gantois@bootlin.com>
>
> How did you guys get it to build?
I haven't :-)
I just reviewed the code, and apparently gcc's parser is stricter than
I am.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-05-22 10:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 12:19 [PATCH v5 0/9] i2c: atr: allow usage of nested ATRs Cosmin Tanislav
2025-05-07 12:19 ` [PATCH v5 1/9] i2c: atr: Fix lockdep for " Cosmin Tanislav
2025-05-22 9:06 ` Wolfram Sang
2025-05-22 9:31 ` Cosmin Tanislav
2025-05-22 10:07 ` Luca Ceresoli
2025-05-22 10:08 ` Luca Ceresoli
2025-05-22 10:11 ` Wolfram Sang
2025-05-07 12:19 ` [PATCH v5 2/9] i2c: atr: find_mapping() -> get_mapping() Cosmin Tanislav
2025-05-07 12:19 ` [PATCH v5 3/9] i2c: atr: split up i2c_atr_get_mapping_by_addr() Cosmin Tanislav
2025-05-21 15:56 ` Luca Ceresoli
2025-05-07 12:19 ` [PATCH v5 4/9] i2c: atr: do not create mapping in detach_addr() Cosmin Tanislav
2025-05-07 12:19 ` [PATCH v5 5/9] i2c: atr: deduplicate logic in attach_addr() Cosmin Tanislav
2025-05-07 12:19 ` [PATCH v5 6/9] i2c: atr: allow replacing mappings " Cosmin Tanislav
2025-05-21 15:56 ` Luca Ceresoli
2025-05-07 12:19 ` [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new() Cosmin Tanislav
2025-05-22 8:50 ` Wolfram Sang
2025-05-22 10:10 ` Luca Ceresoli [this message]
2025-05-07 12:19 ` [PATCH v5 8/9] i2c: atr: add static flag Cosmin Tanislav
2025-05-21 15:56 ` Luca Ceresoli
2025-05-22 8:58 ` Wolfram Sang
2025-05-07 12:19 ` [PATCH v5 9/9] i2c: atr: add passthrough flag Cosmin Tanislav
2025-05-22 10:12 ` [PATCH v5 0/9] i2c: atr: allow usage of nested ATRs Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522121056.685637cd@booty \
--to=luca.ceresoli@bootlin.com \
--cc=arnd@arndb.de \
--cc=demonsingur@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=romain.gantois@bootlin.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.