From: Simon Horman <horms@kernel.org>
To: Bui Quang Minh <minhquangbui99@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] xsk: add missing virtual address conversion for page
Date: Thu, 22 May 2025 13:43:48 +0100 [thread overview]
Message-ID: <20250522124348.GZ365796@horms.kernel.org> (raw)
In-Reply-To: <20250521085633.91565-1-minhquangbui99@gmail.com>
On Wed, May 21, 2025 at 03:56:33PM +0700, Bui Quang Minh wrote:
> In commit 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use
> page_pool_dev_alloc()"), when converting from netmem to page, I missed a
> call to page_address() around skb_frag_page(frag) to get the virtual
> address of the page. This commit uses skb_frag_address() helper to fix
> the issue.
>
> Signed-off-by: Bui Quang Minh <minhquangbui99@gmail.com>
I agree that this is a fix for net-next. But as such I think it needs:
Fixes: 7ead4405e06f ("xsk: convert xdp_copy_frags_from_zc() to use page_pool_dev_alloc()")
Assuming that is correct then I don't think you need to repost just for
this. The tag should be picked up by automation by virtue of being present
in this email.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2025-05-22 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 8:56 [PATCH net-next] xsk: add missing virtual address conversion for page Bui Quang Minh
2025-05-22 12:43 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522124348.GZ365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=minhquangbui99@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.