From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51C53C54E90 for ; Thu, 22 May 2025 13:48:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 24131418A3; Thu, 22 May 2025 13:48:45 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PlLA99YFmMcs; Thu, 22 May 2025 13:48:44 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7476C419CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1747921724; bh=VBLj7J43+So+I8xDAgHLIdQIWBeYy1lB0DB9trhyeWM=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=J88wPzasX+ZEeYayu0riga6CtxbDyNOtQlJP5o41vAx19CivgUYqpXNt0Xl4hCXcI 34M5v6uFvZXRtmcDub7enjYPQwUvdm+8TZSgLaUPlVW+rwO0Y5YsYv+WmX67racIZ2 5d/ToP2rnn3KPkbehXFj1N9Y7Z/gSaqO93IKst3ggF0HCQBZ58iZurnqrS98MG2HAp b+sqxSpmOD3I0pC5lbLzgnbTsI5zQt3rX9VxfG4bZix631YrNdQVHKXp+fWWFlldwi lF3QhVwywjAI0p57Zt+UuhDAlxAHGYriILDuepKcEXxFIZibl0F/c79A0gOl8ZkvYM 0LI3uOJkpizmg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 7476C419CA; Thu, 22 May 2025 13:48:44 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists1.osuosl.org (Postfix) with ESMTP id DBD1B69 for ; Thu, 22 May 2025 13:48:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CE11883E1F for ; Thu, 22 May 2025 13:48:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6vE8bD8cCbgm for ; Thu, 22 May 2025 13:48:42 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 2788583DA7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2788583DA7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2788583DA7 for ; Thu, 22 May 2025 13:48:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AEE255C46C6; Thu, 22 May 2025 13:46:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E036C4CEE4; Thu, 22 May 2025 13:48:39 +0000 (UTC) Date: Thu, 22 May 2025 14:48:37 +0100 From: Simon Horman To: Dawid Osuchowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Martyna Szapar-Mudlaw , Michal Swiatkowski Message-ID: <20250522134837.GG365796@horms.kernel.org> References: <20250521142332.449045-1-dawid.osuchowski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250521142332.449045-1-dawid.osuchowski@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747921720; bh=xPVPJPDU9wpwhb6wXhxg8TZYODtzniGKx7XYTwgsd3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmc/chWXnA2FQb2GzXOWaNgCeC+APRSsP754PvPCQFbZXnbbGrwOrLvtVvcUSQ5XF Q3Y77kOfNt3LwXSvaxHJAWOZCRFXlju9ZUznRb8OmRvCRHUYYMbuWcgi4zSydtShtO hF9vhkTbNMe7V2eVi/NZE7/u4q0FHnoytI6KdNBtFfA8/7gFeANup7H3B+xvGL+CnB rclAha70yCY4pjOytYHNbi3w2PMN+W1xHTv3/WnVqI5fD4GxEBsIF9hajmFk65MLZ9 uglEkuJRq5urgvGFXGt9pXHntg3VMEMbz1bx3LYWL/QUkxAM5DZ4OOyCRI4l2GO5Wg zusPPFA90nfvQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dmc/chWX Subject: Re: [Intel-wired-lan] [PATCH iwl-next] i40e: add link_down_events statistic X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, May 21, 2025 at 04:23:32PM +0200, Dawid Osuchowski wrote: > Introduce a link_down_events counter to the i40e driver, incremented > each time the link transitions from up to down. > This counter can help diagnose issues related to link stability, > such as port flapping or unexpected link drops. > > The value is exposed via ethtool's get_link_ext_stats() interface. > > Co-developed-by: Martyna Szapar-Mudlaw > Signed-off-by: Martyna Szapar-Mudlaw > Reviewed-by: Michal Swiatkowski > Signed-off-by: Dawid Osuchowski > --- > Based on series [1] from Martyna where this was implemented for ixgbe > and ice drivers. > > [1] https://lore.kernel.org/netdev/20250515105011.1310692-1-martyna.szapar-mudlaw@linux.intel.com/ Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 104741EA80 for ; Thu, 22 May 2025 13:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747921721; cv=none; b=UWjn5pq0q+Oe3ckXXqtXa/MoX0LU0GJk1iBIoYKfk4uExcQq4U5kBpl3zbohY0yPDbt+893tlTxZZHY9ImUZdduB6l0NGqh85XzNipmuJsAvJ4fwj87OweLWfkM81XDgxNPxzc/anlcz6KEjZezkL16Zj6riuyoog+aC73BzsCQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747921721; c=relaxed/simple; bh=xPVPJPDU9wpwhb6wXhxg8TZYODtzniGKx7XYTwgsd3U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B+W4yEXut7czHTXPhU6RsiXMx/af1wI9zEsvYhcg1g0P8jvUW5GYwdVs5TL3JYWecivdkgybTfHqWmI0aNg8TCCXEYzDeC4wDNLMnxeB86AXbu6Da6Mh+DY45KmmzRJEp5Bl2QoB3y0MA7+905I9VF9hOyFf/xOFgcGKDx9tbes= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dmc/chWX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dmc/chWX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E036C4CEE4; Thu, 22 May 2025 13:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747921720; bh=xPVPJPDU9wpwhb6wXhxg8TZYODtzniGKx7XYTwgsd3U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dmc/chWXnA2FQb2GzXOWaNgCeC+APRSsP754PvPCQFbZXnbbGrwOrLvtVvcUSQ5XF Q3Y77kOfNt3LwXSvaxHJAWOZCRFXlju9ZUznRb8OmRvCRHUYYMbuWcgi4zSydtShtO hF9vhkTbNMe7V2eVi/NZE7/u4q0FHnoytI6KdNBtFfA8/7gFeANup7H3B+xvGL+CnB rclAha70yCY4pjOytYHNbi3w2PMN+W1xHTv3/WnVqI5fD4GxEBsIF9hajmFk65MLZ9 uglEkuJRq5urgvGFXGt9pXHntg3VMEMbz1bx3LYWL/QUkxAM5DZ4OOyCRI4l2GO5Wg zusPPFA90nfvQ== Date: Thu, 22 May 2025 14:48:37 +0100 From: Simon Horman To: Dawid Osuchowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Martyna Szapar-Mudlaw , Michal Swiatkowski Subject: Re: [PATCH iwl-next] i40e: add link_down_events statistic Message-ID: <20250522134837.GG365796@horms.kernel.org> References: <20250521142332.449045-1-dawid.osuchowski@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250521142332.449045-1-dawid.osuchowski@linux.intel.com> On Wed, May 21, 2025 at 04:23:32PM +0200, Dawid Osuchowski wrote: > Introduce a link_down_events counter to the i40e driver, incremented > each time the link transitions from up to down. > This counter can help diagnose issues related to link stability, > such as port flapping or unexpected link drops. > > The value is exposed via ethtool's get_link_ext_stats() interface. > > Co-developed-by: Martyna Szapar-Mudlaw > Signed-off-by: Martyna Szapar-Mudlaw > Reviewed-by: Michal Swiatkowski > Signed-off-by: Dawid Osuchowski > --- > Based on series [1] from Martyna where this was implemented for ixgbe > and ice drivers. > > [1] https://lore.kernel.org/netdev/20250515105011.1310692-1-martyna.szapar-mudlaw@linux.intel.com/ Reviewed-by: Simon Horman