From: Simon Horman <horms@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: sysfs: Implement is_visible for phys_(port_id, port_name, switch_id)
Date: Thu, 22 May 2025 14:52:07 +0100 [thread overview]
Message-ID: <20250522135207.GH365796@horms.kernel.org> (raw)
In-Reply-To: <20250521140824.3523-1-yajun.deng@linux.dev>
On Wed, May 21, 2025 at 10:08:24PM +0800, Yajun Deng wrote:
> phys_port_id_show, phys_port_name_show and phys_switch_id_show would
> return -EOPNOTSUPP if the netdev didn't implement the corresponding
> method.
>
> There is no point in creating these files if they are unsupported.
>
> Put these attributes in netdev_phys_group and implement the is_visible
> method. make phys_(port_id, port_name, switch_id) invisible if the netdev
> dosen't implement the corresponding method.
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> v2: Remove worthless comments
> v1: https://lore.kernel.org/all/20250515130205.3274-1-yajun.deng@linux.dev/
Reviewed-by: Simon Horman <horms@kernel.org>
FWIIW, I had the same thought that Jakub related in his review of v1.
"I'm slightly worried some user space depends on the files existing,
but maybe ENOENT vs EOPNOTSUPP doesn't make a big difference.|
...
next prev parent reply other threads:[~2025-05-22 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 14:08 [PATCH net-next v2] net: sysfs: Implement is_visible for phys_(port_id, port_name, switch_id) Yajun Deng
2025-05-22 13:52 ` Simon Horman [this message]
2025-05-27 6:08 ` Paolo Abeni
2025-06-12 8:51 ` Yajun Deng
2025-06-12 9:28 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522135207.GH365796@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.