From: Andrew Morton <akpm@linux-foundation.org>
To: Libo Chen <libo.chen@oracle.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
mm-commits@vger.kernel.org, yu.c.chen@intel.com,
vineethr@linux.ibm.com, venkat88@linux.ibm.com, tj@kernel.org,
tim.c.chen@intel.com, shakeel.butt@linux.dev,
roman.gushchin@linux.dev, muchun.song@linux.dev,
mkoutny@suse.com, mingo@redhat.com, mhocko@kernel.org,
mgorman@suse.de, hannes@cmpxchg.org, corbet@lwn.net,
Ayush.jain3@amd.com, aubrey.li@intel.com
Subject: Re: [merged mm-stable] sched-numa-fix-task-swap-by-skipping-kernel-threads.patch removed from -mm tree
Date: Thu, 22 May 2025 14:56:59 -0700 [thread overview]
Message-ID: <20250522145659.91bb0bc4c8affc8e62306e0d@linux-foundation.org> (raw)
In-Reply-To: <27831b60-53f1-4348-b33e-1f30900e29a6@oracle.com>
On Thu, 22 May 2025 03:01:34 -0700 Libo Chen <libo.chen@oracle.com> wrote:
> On 5/21/25 23:31, K Prateek Nayak wrote:
> > On 5/22/2025 2:28 AM, Andrew Morton wrote:
> >> --- a/kernel/sched/fair.c~task_numa_compare-correct-check-for-kernel-thread
> >> +++ a/kernel/sched/fair.c
> >> @@ -2274,7 +2274,7 @@ static bool task_numa_compare(struct tas
> >> rcu_read_lock();
> >> cur = rcu_dereference(dst_rq->curr);
> >> if (cur && ((cur->flags & PF_EXITING) || is_idle_task(cur) ||
> >
> > Question: Shouldn't ...
> >
> > if (cur->flags & (PF_EXITING | PF_KTHREAD))
> > curr = NULL
> >
> > ... be enough?
>
>
> Good point, idle thread is always a kernel thread. I think we can
> remove is_idle_task() in that case
I'll drop the v4 series from mm.git. Let's have a v5, please.
next prev parent reply other threads:[~2025-05-22 21:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 16:56 [merged mm-stable] sched-numa-fix-task-swap-by-skipping-kernel-threads.patch removed from -mm tree Andrew Morton
2025-05-21 19:11 ` Peter Zijlstra
2025-05-21 20:58 ` Andrew Morton
2025-05-22 6:31 ` K Prateek Nayak
2025-05-22 10:01 ` Libo Chen
2025-05-22 21:56 ` Andrew Morton [this message]
2025-05-23 7:48 ` Chen, Yu C
2025-05-22 8:19 ` Michal Koutný
2025-05-22 8:23 ` Peter Zijlstra
2025-05-22 8:36 ` Libo Chen
2025-05-23 5:09 ` Chen, Yu C
2025-05-23 8:21 ` Libo Chen
-- strict thread matches above, loose matches on Subject: below --
2025-06-01 5:47 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250522145659.91bb0bc4c8affc8e62306e0d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Ayush.jain3@amd.com \
--cc=aubrey.li@intel.com \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=kprateek.nayak@amd.com \
--cc=libo.chen@oracle.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=muchun.song@linux.dev \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tim.c.chen@intel.com \
--cc=tj@kernel.org \
--cc=venkat88@linux.ibm.com \
--cc=vineethr@linux.ibm.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.