From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37A63C54E65 for ; Thu, 22 May 2025 17:21:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F243960671; Thu, 22 May 2025 17:21:16 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id oxg92fTCE0_5; Thu, 22 May 2025 17:21:16 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 768CC60E65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1747934476; bh=hQMGsc/f5Q+VmSjd8DM3W+d0MkZNFRIhOQckmIOO+h4=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HOIKfvktU2vdrrhL4t+kkMdTjb2/HKD7ZKeMg/vepqqjkqQaZS3cAaJ1zMR6SuDjp cUSKiZUKGYctHyJwVAvR2imVLXr7/qyLTFjTXnkI0BnR8dlEM7TN8pwBNi5qMNPQEb YnXnH3gAPEIuYmpDwdaOEOWSHmsZIkwjyoka/jXbWQeZSSGLMoMO61JOVsomihoWG+ bsUeNPZndvCfBKyHYUg+jwAAuQ1iAVmkQ6JHhzV+zpnxAgouC5J0pkNNRmtKiK9Pa5 7t1008Zpwjyo11caagi4HoeeI41ptzuu0lXT6B2Ksy5ejvlZkGClp5mmdAQ8CzQSj7 RbZTNkkkLloQA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 768CC60E65; Thu, 22 May 2025 17:21:16 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 4043D237 for ; Thu, 22 May 2025 17:21:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3228C4056D for ; Thu, 22 May 2025 17:21:15 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ah0u9s77SzC4 for ; Thu, 22 May 2025 17:21:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 9C5BB400D2 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9C5BB400D2 Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) by smtp2.osuosl.org (Postfix) with ESMTPS id 9C5BB400D2 for ; Thu, 22 May 2025 17:21:14 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id F3C5762A2B; Thu, 22 May 2025 17:21:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65102C4CEE4; Thu, 22 May 2025 17:21:10 +0000 (UTC) Date: Thu, 22 May 2025 18:21:08 +0100 From: Simon Horman To: Alok Tiwari Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, darren.kenny@oracle.com Message-ID: <20250522172108.GK365796@horms.kernel.org> References: <20250522074734.3634633-1-alok.a.tiwari@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250522074734.3634633-1-alok.a.tiwari@oracle.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747934472; bh=IHokm80AvQoeLm7V8X5gQdcJ8Sn6Kew2FcZbLHZKjOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g4LutPHn7c8o3nAYAn8ij9FvAMc5D1Bur8iwE8oA1I1UlW/5ghPTzVeKCHUGyDRko dk2Gm6MMkuM5P232UB+qMASq7h1gz8zegWSQqbbksGV2DnREdByoJPsrryIWtg/zir ZUWxBhb1NDsumgfhknDWzQCQIuSZVMZYcsyXVUuwjq4Jc34cH8h8pNWApPRx/x4gwi 4m/kDOblhP6qYp/Vi7xmKJYpvANMQ3/iYHpTAQo5nFBLP/gfpbCo44tCRN779x+aOF PMfLEMLenKqBQYAwyNGKN99VPoorI1q9UhRp4eOg7Q7nzGJaH8zqTcWr9cx0HCjMuG 2I5ctQB4qgnIw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=g4LutPHn Subject: Re: [Intel-wired-lan] [PATCH] ixgbe: Fix typos and clarify comments in X550 driver code X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, May 22, 2025 at 12:47:26AM -0700, Alok Tiwari wrote: > Corrected spelling errors such as "simular" -> "similar", > "excepted" -> "accepted", and "Determime" -> "Determine". > Fixed including incorrect word usage ("to MAC" -> "two MAC") > and improved awkward phrasing. > > Aligned function header descriptions with their actual functionality > (e.g., "Writes a value" -> "Reads a value"). > Corrected typo in error code from -ENIVAL to -EINVAL. > Improved overall clarity and consistency in comment across various > functions. > > These changes improve maintainability and readability of the code > without affecting functionality. > > Signed-off-by: Alok Tiwari > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 28 +++++++++---------- ... > @@ -1754,7 +1754,7 @@ ixgbe_setup_mac_link_sfp_n(struct ixgbe_hw *hw, ixgbe_link_speed speed, > ret_val = ixgbe_supported_sfp_modules_X550em(hw, &setup_linear); > > /* If no SFP module present, then return success. Return success since > - * SFP not present error is not excepted in the setup MAC link flow. > + * SFP not present error is not accepted in the setup MAC link flow. I wonder if "excepted" was supposed to be "expected". > */ > if (ret_val == -ENOENT) > return 0; > @@ -1804,7 +1804,7 @@ ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw, ixgbe_link_speed speed, > ret_val = ixgbe_supported_sfp_modules_X550em(hw, &setup_linear); > > /* If no SFP module present, then return success. Return success since > - * SFP not present error is not excepted in the setup MAC link flow. > + * SFP not present error is not accepted in the setup MAC link flow. Ditto. > */ > if (ret_val == -ENOENT) > return 0; The above notwithstanding, this looks good to me. Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389E5194094; Thu, 22 May 2025 17:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934473; cv=none; b=JXewXva/M6AbRJujU4pcr1tmTNAmSRcvDOBd72wlkd8/we6b3t6N0UGhfzLjemVwiVstHOhMdxpxLg9uORmJ66mp3MNhjlhCprwTnKrg361p6pZAzFsSEBJDgUgbD/CBne6gWcaVga3NxMJ36K6Kubv8hUJX+ebnF1c/Kd+YfZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934473; c=relaxed/simple; bh=IHokm80AvQoeLm7V8X5gQdcJ8Sn6Kew2FcZbLHZKjOg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sBLTFmkf6dNzx7Ge23u/P4+A4fzSHQ9vIW7an7TE6Ts71eZVHD42zE8T7+z5Crb0TjjOL95HylEdzuZ2WGZMtnkwX31bsBa8nrZEkpYrJEldxQt9FVcKAEcljKyF2AzS+GSQsWCAuwF06NGWFzjZFIls6OR8wWdM78IxU6sFd1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g4LutPHn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g4LutPHn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65102C4CEE4; Thu, 22 May 2025 17:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747934472; bh=IHokm80AvQoeLm7V8X5gQdcJ8Sn6Kew2FcZbLHZKjOg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g4LutPHn7c8o3nAYAn8ij9FvAMc5D1Bur8iwE8oA1I1UlW/5ghPTzVeKCHUGyDRko dk2Gm6MMkuM5P232UB+qMASq7h1gz8zegWSQqbbksGV2DnREdByoJPsrryIWtg/zir ZUWxBhb1NDsumgfhknDWzQCQIuSZVMZYcsyXVUuwjq4Jc34cH8h8pNWApPRx/x4gwi 4m/kDOblhP6qYp/Vi7xmKJYpvANMQ3/iYHpTAQo5nFBLP/gfpbCo44tCRN779x+aOF PMfLEMLenKqBQYAwyNGKN99VPoorI1q9UhRp4eOg7Q7nzGJaH8zqTcWr9cx0HCjMuG 2I5ctQB4qgnIw== Date: Thu, 22 May 2025 18:21:08 +0100 From: Simon Horman To: Alok Tiwari Cc: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, darren.kenny@oracle.com Subject: Re: [PATCH] ixgbe: Fix typos and clarify comments in X550 driver code Message-ID: <20250522172108.GK365796@horms.kernel.org> References: <20250522074734.3634633-1-alok.a.tiwari@oracle.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250522074734.3634633-1-alok.a.tiwari@oracle.com> On Thu, May 22, 2025 at 12:47:26AM -0700, Alok Tiwari wrote: > Corrected spelling errors such as "simular" -> "similar", > "excepted" -> "accepted", and "Determime" -> "Determine". > Fixed including incorrect word usage ("to MAC" -> "two MAC") > and improved awkward phrasing. > > Aligned function header descriptions with their actual functionality > (e.g., "Writes a value" -> "Reads a value"). > Corrected typo in error code from -ENIVAL to -EINVAL. > Improved overall clarity and consistency in comment across various > functions. > > These changes improve maintainability and readability of the code > without affecting functionality. > > Signed-off-by: Alok Tiwari > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 28 +++++++++---------- ... > @@ -1754,7 +1754,7 @@ ixgbe_setup_mac_link_sfp_n(struct ixgbe_hw *hw, ixgbe_link_speed speed, > ret_val = ixgbe_supported_sfp_modules_X550em(hw, &setup_linear); > > /* If no SFP module present, then return success. Return success since > - * SFP not present error is not excepted in the setup MAC link flow. > + * SFP not present error is not accepted in the setup MAC link flow. I wonder if "excepted" was supposed to be "expected". > */ > if (ret_val == -ENOENT) > return 0; > @@ -1804,7 +1804,7 @@ ixgbe_setup_mac_link_sfp_x550a(struct ixgbe_hw *hw, ixgbe_link_speed speed, > ret_val = ixgbe_supported_sfp_modules_X550em(hw, &setup_linear); > > /* If no SFP module present, then return success. Return success since > - * SFP not present error is not excepted in the setup MAC link flow. > + * SFP not present error is not accepted in the setup MAC link flow. Ditto. > */ > if (ret_val == -ENOENT) > return 0; The above notwithstanding, this looks good to me. Reviewed-by: Simon Horman