Re: [PATCH 5/5] nvmet: implement copy support for bdev backed target

[kernel test robot <lkp@intel.com>]

Hi Keith,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on next-20250522]
[cannot apply to linux-nvme/for-next brauner-vfs/vfs.all linus/master v6.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/block-new-sector-copy-api/20250522-063316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20250521223107.709131-6-kbusch%40meta.com
patch subject: [PATCH 5/5] nvmet: implement copy support for bdev backed target
config: csky-randconfig-r132-20250522 (https://download.01.org/0day-ci/archive/20250522/202505222048.SmFqu3B0-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 15.1.0
reproduce: (https://download.01.org/0day-ci/archive/20250522/202505222048.SmFqu3B0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505222048.SmFqu3B0-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/target/io-cmd-bdev.c:447:62: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __le64 [usertype] lba @@     got unsigned long long [assigned] [usertype] slba @@
   drivers/nvme/target/io-cmd-bdev.c:447:62: sparse:     expected restricted __le64 [usertype] lba
   drivers/nvme/target/io-cmd-bdev.c:447:62: sparse:     got unsigned long long [assigned] [usertype] slba
>> drivers/nvme/target/io-cmd-bdev.c:448:63: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted __le64 [usertype] lba @@     got unsigned short [assigned] [usertype] nlb @@
   drivers/nvme/target/io-cmd-bdev.c:448:63: sparse:     expected restricted __le64 [usertype] lba
   drivers/nvme/target/io-cmd-bdev.c:448:63: sparse:     got unsigned short [assigned] [usertype] nlb
>> drivers/nvme/target/io-cmd-bdev.c:454:35: sparse: sparse: cast to restricted __le64

vim +447 drivers/nvme/target/io-cmd-bdev.c

   419	
   420	static void nvmet_bdev_execute_copy(struct nvmet_req *req)
   421	{
   422		struct bio_vec *bv, fast_bv[UIO_FASTIOV];
   423		struct nvme_copy_range range;
   424		u64 dst_sector, slba;
   425		u16 status, nlb, nr;
   426		int ret, i;
   427	
   428		nr = req->cmd->copy.nr_range + 1;
   429		if (nr <= UIO_FASTIOV) {
   430			bv = fast_bv;
   431		} else {
   432			bv = kmalloc_array(nr, sizeof(*bv), GFP_KERNEL);
   433			if (!bv) {
   434				status = NVME_SC_INTERNAL;
   435				goto done;
   436			}
   437		}
   438	
   439		for (i = 0; i < nr; i++) {
   440			status = nvmet_copy_from_sgl(req, i * sizeof(range), &range,
   441					sizeof(range));
   442			if (status)
   443				goto done;
   444	
   445			slba = le64_to_cpu(range.slba);
   446			nlb = le16_to_cpu(range.nlb) + 1;
 > 447			bv[i].bv_sector = nvmet_lba_to_sect(req->ns, slba);
 > 448			bv[i].bv_sectors = nvmet_lba_to_sect(req->ns, nlb);
   449		}
   450	
   451		dst_sector = nvmet_lba_to_sect(req->ns, req->cmd->copy.sdlba);
   452		ret = blkdev_copy_range(req->ns->bdev, dst_sector, bv, nr, GFP_KERNEL);
   453		if (ret) {
 > 454			req->error_slba = le64_to_cpu(dst_sector);
   455			status = errno_to_nvme_status(req, ret);
   456		} else
   457			status = NVME_SC_SUCCESS;
   458	done:
   459		nvmet_req_complete(req, status);
   460		if (bv != fast_bv)
   461			kfree(bv);
   462	}
   463	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki