All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Brigham Campbell <me@brighamcampbell.com>
Cc: Jihed Chaibi <jihed.chaibi.dev@gmail.com>,
	heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org
Subject: Re: [PATCH 1/1] usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro
Date: Thu, 22 May 2025 10:30:48 +0200	[thread overview]
Message-ID: <2025052234-brewing-recall-a7ed@gregkh> (raw)
In-Reply-To: <DA2IV4ZGT2M8.3QXO3L57VXSA5@brighamcampbell.com>

On Thu, May 22, 2025 at 01:47:54AM -0600, Brigham Campbell wrote:
> On Wed May 21, 2025 at 3:48 PM MDT, Jihed Chaibi wrote:
> > "VOLAGE" should become "VOLTAGE"
> >
> > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@gmail.com>
> 
> Nice work! I was able to successfully compile this driver with your
> changes and I don't see any further references to the misspelled macro.
> 
> Patches which fix issues which were introduced in some previous commit
> typically indicate the offending commit via the "Fixes" tag. Admittedly,
> I don't know if the tag is reserved for technical bugs rather than typos
> such as the one you addressed, but such a tag would look like the
> following for this patch:
> 
> Fixes: e011178579b57c03 ("usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro")

Too many characters for that sha1 value :)

thanks,

greg k-hj

  reply	other threads:[~2025-05-22  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21 21:48 [PATCH 1/1] usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro Jihed Chaibi
2025-05-22  7:47 ` Brigham Campbell
2025-05-22  8:30   ` Greg KH [this message]
2025-05-22 11:10     ` Jihed Chaibi
2025-05-22 16:21     ` Brigham Campbell
2025-05-22 16:36       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025052234-brewing-recall-a7ed@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jihed.chaibi.dev@gmail.com \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=me@brighamcampbell.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.