All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Wang <wei.w.wang@intel.com>
To: baolu.lu@linux.intel.com, kevin.tian@intel.com,
	yi.l.liu@intel.com, dwmw2@infradead.org, jroedel@suse.de,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Cc: Wei Wang <wei.w.wang@intel.com>
Subject: [PATCH v1] iommu/vt-d: Remove the redundant logic in first_level_by_default()
Date: Fri, 23 May 2025 16:10:56 +0800	[thread overview]
Message-ID: <20250523081056.223082-1-wei.w.wang@intel.com> (raw)

This original implementation included redundant logic to determine whether
first-stage translation should be used by default. Simplify it and
preserve the original behavior:
- Returns false in legacy mode (no scalable mode support).
- Defaults to first-level translation when both FLTS and SLTS are
  supported.

Signed-off-by: Wei Wang <wei.w.wang@intel.com>
---
 drivers/iommu/intel/iommu.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index cb0b993bebb4..228da47ab7cd 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -1366,15 +1366,7 @@ static void free_dmar_iommu(struct intel_iommu *iommu)
  */
 static bool first_level_by_default(struct intel_iommu *iommu)
 {
-	/* Only SL is available in legacy mode */
-	if (!sm_supported(iommu))
-		return false;
-
-	/* Only level (either FL or SL) is available, just use it */
-	if (ecap_flts(iommu->ecap) ^ ecap_slts(iommu->ecap))
-		return ecap_flts(iommu->ecap);
-
-	return true;
+	return sm_supported(iommu) && ecap_flts(iommu->ecap);
 }
 
 int domain_attach_iommu(struct dmar_domain *domain, struct intel_iommu *iommu)
-- 
2.43.0


             reply	other threads:[~2025-05-23  0:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23  8:10 Wei Wang [this message]
2025-05-23  8:15 ` [PATCH v1] iommu/vt-d: Remove the redundant logic in first_level_by_default() Tian, Kevin
2025-05-29  5:48 ` Ethan Zhao
2025-05-29  6:11   ` Tian, Kevin
2025-06-04  7:25     ` Ethan Zhao
2025-06-05  1:04       ` Wang, Wei W
2025-06-05  3:33         ` Ethan Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250523081056.223082-1-wei.w.wang@intel.com \
    --to=wei.w.wang@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=jroedel@suse.de \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.