From: Christoph Hellwig <hch@lst.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: oe-kbuild@lists.linux.dev, Christoph Hellwig <hch@lst.de>,
lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Carlos Maiolino <cem@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [linux-next:master 10746/11779] fs/xfs/xfs_mru_cache.c:451 xfs_mru_cache_insert() error: we previously assumed 'mru' could be null (see line 429)
Date: Fri, 23 May 2025 12:06:40 +0200 [thread overview]
Message-ID: <20250523100640.GA23844@lst.de> (raw)
In-Reply-To: <202505211940.jjLX0rQI-lkp@intel.com>
On Fri, May 23, 2025 at 12:58:57PM +0300, Dan Carpenter wrote:
> 2a82b8be8a8dac David Chinner 2007-07-11 428 ASSERT(mru && mru->lists);
> 2a82b8be8a8dac David Chinner 2007-07-11 @429 if (!mru || !mru->lists)
>
> mru can't be NULL but if it were
>
> 70b95cb86513d7 Christoph Hellwig 2025-05-14 450 out_free:
> 70b95cb86513d7 Christoph Hellwig 2025-05-14 @451 mru->free_func(mru->data, elem);
>
> then we are toast.
Yeah. Fortunately it is just a debug check for an invalid API.
I'd be tempted to just remove the check and only leave in the assert
for the same condition right above.
prev parent reply other threads:[~2025-05-23 10:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 11:24 [linux-next:master 10746/11779] fs/xfs/xfs_mru_cache.c:451 xfs_mru_cache_insert() error: we previously assumed 'mru' could be null (see line 429) kernel test robot
2025-05-23 9:58 ` Dan Carpenter
2025-05-23 10:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523100640.GA23844@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.