From: Lee Jones <lee@kernel.org>
To: nuno.sa@analog.com
Cc: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-input@vger.kernel.org,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Liu Ying" <victor.liu@nxp.com>
Subject: Re: [PATCH v4 04/20] mfd: adp5585: make use of MFD_CELL_NAME()
Date: Fri, 23 May 2025 15:53:02 +0100 [thread overview]
Message-ID: <20250523145302.GG1378991@google.com> (raw)
In-Reply-To: <20250521-dev-adp5589-fw-v4-4-f2c988d7a7a0@analog.com>
On Wed, 21 May 2025, Nuno Sá via B4 Relay wrote:
> From: Nuno Sá <nuno.sa@analog.com>
>
> Use the helper macro. No functional change intended...
"Whilst we're at it, now seems like a good time to update the Copyright."
Or similar.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> drivers/mfd/adp5585.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/adp5585.c b/drivers/mfd/adp5585.c
> index f3b74f7d6040413d066eb6dbaecfa3d5e6ee06bd..179dc284833ae8f39eefc6787dd2c7158dfd3ad7 100644
> --- a/drivers/mfd/adp5585.c
> +++ b/drivers/mfd/adp5585.c
> @@ -4,6 +4,7 @@
> *
> * Copyright 2022 NXP
> * Copyright 2024 Ideas on Board Oy
> + * Copyright 2025 Analog Devices Inc.
> */
>
> #include <linux/array_size.h>
> @@ -24,8 +25,8 @@ enum {
> };
>
> static const struct mfd_cell adp5585_devs[ADP5585_DEV_MAX] = {
> - { .name = "adp5585-gpio", },
> - { .name = "adp5585-pwm", },
> + MFD_CELL_NAME("adp5585-gpio"),
> + MFD_CELL_NAME("adp5585-pwm"),
> };
>
> static const struct regmap_range adp5585_volatile_ranges[] = {
>
> --
> 2.49.0
>
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-05-23 14:53 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 13:02 [PATCH v4 00/20] mfd: adp5585: support keymap events and drop legacy Input driver Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-21 13:02 ` [PATCH v4 01/20] dt-bindings: mfd: adp5585: ease on the required properties Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-21 13:02 ` [PATCH v4 02/20] mfd: adp5585: only add devices given in FW Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-23 14:51 ` Lee Jones
2025-05-23 15:07 ` Nuno Sá
2025-05-23 15:19 ` Lee Jones
2025-05-23 15:45 ` Nuno Sá
2025-06-12 14:17 ` Lee Jones
2025-05-21 13:02 ` [PATCH v4 03/20] mfd: adp5585: enable oscilator during probe Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-06-12 14:20 ` Lee Jones
2025-06-12 14:40 ` Nuno Sá
2025-06-12 15:20 ` Lee Jones
2025-06-13 9:43 ` Nuno Sá
2025-05-21 13:02 ` [PATCH v4 04/20] mfd: adp5585: make use of MFD_CELL_NAME() Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-23 14:53 ` Lee Jones [this message]
2025-05-21 13:02 ` [PATCH v4 05/20] dt-bindings: mfd: adp5585: document adp5589 I/O expander Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-21 13:02 ` [PATCH v4 06/20] mfd: adp5585: refactor how regmap defaults are handled Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-23 15:03 ` Lee Jones
2025-05-27 10:08 ` Nuno Sá
2025-05-21 13:02 ` [PATCH v4 07/20] mfd: adp5585: add support for adp5589 Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-23 15:15 ` Lee Jones
2025-05-27 10:20 ` Nuno Sá
2025-05-21 13:02 ` [PATCH v4 08/20] mfd: adp5585: add a per chip reg struture Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-06-12 14:22 ` Lee Jones
2025-05-21 13:02 ` [PATCH v4 09/20] gpio: adp5585: add support for the adp5589 expander Nuno Sá
2025-05-21 13:02 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 10/20] pwm: adp5585: add support for adp5589 Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 11/20] dt-bindings: mfd: adp5585: add properties for input events Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 12/20] mfd: adp5585: add support for event handling Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-06-12 14:29 ` Lee Jones
2025-05-21 13:03 ` [PATCH v4 13/20] mfd: adp5585: support reset and unlock events Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-06-12 14:55 ` Lee Jones
2025-06-13 9:48 ` Nuno Sá
2025-06-13 13:07 ` Lee Jones
2025-06-13 13:13 ` Nuno Sá
2025-06-13 13:27 ` Lee Jones
2025-05-21 13:03 ` [PATCH v4 14/20] mfd: adp5585: add support for input devices Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-06-12 15:16 ` Lee Jones
2025-05-21 13:03 ` [PATCH v4 15/20] gpio: adp5585: support gpi events Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 16/20] Input: adp5585: Add Analog Devices ADP5585/89 support Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 17/20] Input: adp5589: remove the driver Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 18/20] mfd: adp5585: support getting vdd regulator Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-06-12 15:17 ` Lee Jones
2025-05-21 13:03 ` [PATCH v4 19/20] dt-bindings: mfd: adp5585: document reset gpio Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-05-21 13:03 ` [PATCH v4 20/20] mfd: adp5585: add support for a reset pin Nuno Sá
2025-05-21 13:03 ` Nuno Sá via B4 Relay
2025-06-12 15:18 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250523145302.GG1378991@google.com \
--to=lee@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.