Re: [Intel-wired-lan] [PATCH net-next v4 2/3] dpll: add reference sync get/set

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250523172650.1517164-3-arkadiusz.kubalewski@intel.com>
References: <20250523172650.1517164-3-arkadiusz.kubalewski@intel.com>
TO: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
TO: donald.hunter@gmail.com
TO: kuba@kernel.org
TO: davem@davemloft.net
TO: edumazet@google.com
TO: pabeni@redhat.com
TO: horms@kernel.org
TO: vadim.fedorenko@linux.dev
TO: jiri@resnulli.us
TO: anthony.l.nguyen@intel.com
TO: przemyslaw.kitszel@intel.com
TO: andrew+netdev@lunn.ch
TO: aleksandr.loktionov@intel.com
TO: corbet@lwn.net
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: intel-wired-lan@lists.osuosl.org
CC: linux-rdma@vger.kernel.org
CC: linux-doc@vger.kernel.org
CC: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
CC: Milena Olech <milena.olech@intel.com>

Hi Arkadiusz,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ea15e046263b19e91ffd827645ae5dfa44ebd044]

url:    https://github.com/intel-lab-lkp/linux/commits/Arkadiusz-Kubalewski/dpll-add-reference-sync-netlink-attribute/20250524-013615
base:   ea15e046263b19e91ffd827645ae5dfa44ebd044
patch link:    https://lore.kernel.org/r/20250523172650.1517164-3-arkadiusz.kubalewski%40intel.com
patch subject: [Intel-wired-lan] [PATCH net-next v4 2/3] dpll: add reference sync get/set
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: x86_64-randconfig-161-20250524 (https://download.01.org/0day-ci/archive/20250525/202505250848.GBC8s5Wc-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202505250848.GBC8s5Wc-lkp@intel.com/

New smatch warnings:
drivers/dpll/dpll_core.c:670 dpll_pin_ref_sync_pair_del() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:998 dpll_pin_ref_sync_state_set() warn: iterator 'i' not incremented

Old smatch warnings:
drivers/dpll/dpll_core.c:82 dpll_xa_ref_pin_add() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:134 dpll_xa_ref_pin_del() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:163 dpll_xa_ref_dpll_add() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:215 dpll_xa_ref_dpll_del() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:235 dpll_xa_ref_dpll_first() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:568 dpll_pin_get() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:764 dpll_pin_on_pin_register() warn: iterator 'i' not incremented
drivers/dpll/dpll_core.c:798 dpll_pin_on_pin_unregister() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:62 dpll_pin_available() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:846 dpll_pin_freq_set() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:1061 dpll_pin_on_pin_state_set() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:1219 dpll_pin_phase_adj_set() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:1366 dpll_pin_find() warn: iterator 'i' not incremented
drivers/dpll/dpll_netlink.c:1569 dpll_device_find() warn: iterator 'i' not incremented

vim +/i +670 drivers/dpll/dpll_core.c

9431063ad323ac Vadim Fedorenko      2023-09-13  664  
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  665  static void dpll_pin_ref_sync_pair_del(u32 ref_sync_pin_id)
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  666  {
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  667  	struct dpll_pin *pin, *ref_sync_pin;
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  668  	unsigned long i;
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  669  
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23 @670  	xa_for_each(&dpll_pin_xa, i, pin) {
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  671  		ref_sync_pin = xa_load(&pin->ref_sync_pins, ref_sync_pin_id);
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  672  		if (ref_sync_pin) {
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  673  			xa_erase(&pin->ref_sync_pins, ref_sync_pin_id);
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  674  			__dpll_pin_change_ntf(pin);
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  675  		}
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  676  	}
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  677  }
d487dd9d1b2560 Arkadiusz Kubalewski 2025-05-23  678  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki