From: Johan Adolfsson <johan.adolfsson@axis.com>
To: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
Johan Adolfsson <johan.adolfsson@axis.com>, <kernel@axis.com>
Subject: [PATCH RFC v4 2/2] dt-bindings: leds: lp50xx: Document child reg, fix example
Date: Mon, 26 May 2025 16:54:01 +0200 [thread overview]
Message-ID: <20250526-led-fix-v4-2-33345f6c4a78@axis.com> (raw)
In-Reply-To: <20250526-led-fix-v4-0-33345f6c4a78@axis.com>
The led child reg node is the index within the bank, document that
and update the example accordingly.
Signed-off-by: Johan Adolfsson <johan.adolfsson@axis.com>
---
.../devicetree/bindings/leds/leds-lp50xx.yaml | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
index 402c25424525..a7b2d87cc39d 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
@@ -81,7 +81,12 @@ patternProperties:
properties:
reg:
- maxItems: 1
+ minimum: 0
+ maximum: 2
+ description:
+ This property denotes the index within the LED bank.
+ The value will act as the index in the multi_index file to give
+ consistent result independent of devicetree processing order.
required:
- reg
@@ -138,18 +143,18 @@ examples:
color = <LED_COLOR_ID_RGB>;
function = LED_FUNCTION_STANDBY;
- led@3 {
- reg = <0x3>;
+ led@0 {
+ reg = <0x0>;
color = <LED_COLOR_ID_RED>;
};
- led@4 {
- reg = <0x4>;
+ led@1 {
+ reg = <0x1>;
color = <LED_COLOR_ID_GREEN>;
};
- led@5 {
- reg = <0x5>;
+ led@2 {
+ reg = <0x2>;
color = <LED_COLOR_ID_BLUE>;
};
};
--
2.30.2
next prev parent reply other threads:[~2025-05-26 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-26 14:53 [PATCH RFC v4 0/2] leds-lp50xx: Support reg to set multi_index Johan Adolfsson
2025-05-26 14:54 ` [PATCH RFC v4 1/2] leds: leds-lp50xx: Handle reg to get correct multi_index Johan Adolfsson
2025-05-26 21:54 ` Jacek Anaszewski
2025-06-12 10:53 ` Lee Jones
2025-06-14 13:38 ` Jacek Anaszewski
2025-06-19 10:02 ` Lee Jones
2025-05-26 14:54 ` Johan Adolfsson [this message]
2025-05-26 15:34 ` [PATCH RFC v4 2/2] dt-bindings: leds: lp50xx: Document child reg, fix example Krzysztof Kozlowski
2025-05-26 16:42 ` Johan Adolfsson
2025-05-27 5:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250526-led-fix-v4-2-33345f6c4a78@axis.com \
--to=johan.adolfsson@axis.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.