Re: [PATCH 2/2] media: uapi: Document IOCTL number assignment

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thank you for the patch.


On Mon, May 26, 2025 at 02:17:32PM +0300, Sakari Ailus wrote:
> Document MC IOCTL number assignment in linux/media.h. In the past the
> assignment up to 0x7f was missed so to prevent that from happening again,
> document the value here as well.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  include/uapi/linux/media.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index 1c80b1d6bbaf..2808132fcf49 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -381,6 +381,10 @@ struct media_v2_topology {
>   */
>  #define MEDIA_REQUEST_IOC_QUEUE		_IO('|',  0x80)
>  #define MEDIA_REQUEST_IOC_REINIT	_IO('|',  0x81)
> +/*
> + * Don't allocate new IOCTL numbers past 0x8f, MC IOCTL number assignment ends
> + * there!
> + */
>  
>  #ifndef __KERNEL__
>  

-- 
Regards,

Laurent Pinchart