Re: [PATCH] mm/damon: rename primitives to operations

[SeongJae Park <sj@kernel.org>]

Hi David,

On Mon, 26 May 2025 11:31:45 +0200 David Hildenbrand <david@redhat.com> wrote:

> On 24.05.25 18:29, SeongJae Park wrote:
> > Hi Enze,
> > 
> > On Sat, 24 May 2025 20:55:36 +0800 Enze Li <lienze@kylinos.cn> wrote:
> > 
> >> The word 'primitive' is not explicit and has been deprecated in DAMON's
> >> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to
> >> damon_operations").  To make the code easier to be understand, this
> >> commit renames remaining 'primitives' to 'operations' in header comments
> >> of DAMON source files.
> > 
> > Thank you for this patch!  The description makes sense to me.
> > 
> > The title makes me bit confused, though.  By reading it, I was assuming this
> > patch is changing some code.  But this is changing only comments.  Could you
> > please make the title more clearly specify that?  E.g., "fix outdated comments
> > for monitoring primitives"?
> 
> Heh, but wouldn't we be calling this things "primitives" in the current 
> context?

Thanks for giving us this good point.  I was reading this as "fix outdated
comments for monitoring primitives (, which is a deprecated term)".  And I
agree this is not very clear.

> 
> "don't refer to common code as 'primitives'"

Nice suggestion.  But, this wouldn't explain the changes to {p,v}addr.c files,
since those are not for common code.

Maybe "mm/damon: s/primitives/code/ on comments" could also be a simple and not
that bad title?


Thanks,
SJ

> 
> -- 
> Cheers,
> 
> David / dhildenb