From: "Jₑₙₛ Gustedt" <jens.gustedt@inria.fr>
To: Carlos O'Donell <carlos@redhat.com>
Cc: Alejandro Colomar <alx@kernel.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
linux-man@vger.kernel.org, Ulrich Drepper <drepper@redhat.com>,
Ingo Molnar <mingo@kernel.org>, Todd Lewis <todd.lewis@gs.com>,
Alexandre Oliva <aoliva@redhat.com>
Subject: Re: bug in futex.2, FUTEX_CMP_REQUEUE
Date: Tue, 27 May 2025 14:28:12 +0200 [thread overview]
Message-ID: <20250527142812.51ee1c30@inria.fr> (raw)
In-Reply-To: <7d4c29a5-6836-48bd-a6c8-009264be000c@redhat.com>
Hello again,
On Tue, 27 May 2025 08:12:41 -0400, Carlos O'Donell wrote:
> > Fixes: 3dfcc11d4630 (2015-12-15; "futex.2: Expand
> > description of FUTEX_CMP_REQUEUE") Fixes: 8297383e9eeb (2015-12-15;
> > "futex.2: Clean-ups and FIXME removeal after feedback from Thomas
> > Gleixner") Reported-by: Jens Gustedt <jens.gustedt@inria.fr>
> > Signed-off-by: Alejandro Colomar <alx@kernel.org>
> >
> > diff --git a/man/man2/futex.2 b/man/man2/futex.2
> > index 128612ee1..9a15a0fdb 100644
> > --- a/man/man2/futex.2
> > +++ b/man/man2/futex.2
> > @@ -501,7 +501,7 @@ .SS Futex operations
> > (Specifying the argument as 0 is not useful, because it
> > would make the .B FUTEX_CMP_REQUEUE
> > operation equivalent to
> > -.BR FUTEX_WAIT .)
> > +.BR FUTEX_WAKE .)
>
> This is incorrect.
>
> A value of zero means no tasks are woken.
No, `val2 == 0` means that as many as specified in `val` are woken,
and that no task additionally is queued on `uaddr2`. So this is
definitively a wake operation.
The resulting text is then not completely correct, because it is
missing the tests for `val3` but at least is a bit closer to reality
than before.
Thanks
Jₑₙₛ
--
:: ICube :::::::::::::::::::::::::::::: deputy director ::
:: Université de Strasbourg :::::::::::::::::::::: ICPS ::
:: INRIA antenne de Strasbourg :::::::::::::::::: Camus ::
:: INRIA PIQ program Strasbourg :::::::::: piq.inria.fr ::
:: :::::::::::::::::::::::::::::::::::: ☎ +33 368854536 ::
:: https://icube-icps.unistra.fr/index.php/Jens_Gustedt ::
next prev parent reply other threads:[~2025-05-27 12:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 9:53 bug in futex.2, FUTEX_CMP_REQUEUE Jₑₙₛ Gustedt
2025-05-27 11:30 ` Carlos O'Donell
2025-05-27 12:21 ` Jₑₙₛ Gustedt
2025-05-27 12:28 ` Carlos O'Donell
2025-05-27 12:23 ` Alejandro Colomar
2025-05-27 12:35 ` Carlos O'Donell
2025-05-27 12:01 ` Alejandro Colomar
2025-05-27 12:12 ` Carlos O'Donell
2025-05-27 12:28 ` Jₑₙₛ Gustedt [this message]
2025-05-27 12:37 ` Carlos O'Donell
2025-05-27 12:51 ` Alejandro Colomar
2025-05-27 12:54 ` Carlos O'Donell
2025-05-27 12:28 ` Alejandro Colomar
2025-05-27 12:42 ` Carlos O'Donell
2025-05-27 12:57 ` Alejandro Colomar
2025-05-27 12:59 ` Alejandro Colomar
2025-05-27 13:07 ` Jₑₙₛ Gustedt
2025-05-29 23:35 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527142812.51ee1c30@inria.fr \
--to=jens.gustedt@inria.fr \
--cc=alx@kernel.org \
--cc=aoliva@redhat.com \
--cc=carlos@redhat.com \
--cc=drepper@redhat.com \
--cc=linux-man@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=todd.lewis@gs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.