From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Moshe Shemesh <moshe@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Gal Pressman <gal@nvidia.com>, Yael Chemla <ychemla@nvidia.com>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: Log error messages when extack is not present
Date: Tue, 27 May 2025 17:49:55 -0700 [thread overview]
Message-ID: <20250527174955.594f3617@kernel.org> (raw)
In-Reply-To: <1748173652-1377161-3-git-send-email-tariqt@nvidia.com>
On Sun, 25 May 2025 14:47:32 +0300 Tariq Toukan wrote:
> Encapsulate netlink error message macros to ensure error message remain
> visible in dmesg when the userspace does not support netlink.
>
> This allows drivers to continue providing meaningful error messages even
> when netlink is available in kernel but not in userspace.
>
> Replace direct extack macro calls with new wrapper macros to support
> this fallback behavior.
Please break this down API by API and explain for each why user space
can't use netlink. If we thought this was a good idea we would have
added the pr_err() to the NL_SET_ERR_MSG_MOD() from the start.
--
pw-bot: cr
next prev parent reply other threads:[~2025-05-28 0:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-25 11:47 [PATCH net-next 0/2] net/mlx5: misc changes 2025-05-25 Tariq Toukan
2025-05-25 11:47 ` [PATCH net-next 1/2] net/mlx5: Warn when write combining is not supported Tariq Toukan
2025-05-25 11:47 ` [PATCH net-next 2/2] net/mlx5e: Log error messages when extack is not present Tariq Toukan
2025-05-28 0:49 ` Jakub Kicinski [this message]
2025-06-03 21:01 ` Yael Chemla
2025-06-04 2:50 ` Jakub Kicinski
2025-06-04 10:23 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250527174955.594f3617@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ychemla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.